IBX-8019: Replaced LocationService::loadLocationChildren use with SearchService
#2119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was referenced Jun 3, 2024
konradoboza
approved these changes
Jun 3, 2024
Nattfarinn
approved these changes
Jun 3, 2024
ciastektk
approved these changes
Jun 3, 2024
mikadamczyk
approved these changes
Jun 3, 2024
tomaszszopinski
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After investigating performance issues described in the ticket, the conclusion is we are at the limit how the query can be optimized. The solution is to delegate loading Location children to Search Engine whenever possible.
Related PRs:
LocationService::loadLocationChildrenezplatform-kernel#407LocationService::loadLocationChildrenuse withSearchService#2119SearchService::findLocationsezrecommendation-client#114Checklist:
$ composer fix-cs)