-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix EZP-21963: create separate "promise-based" build #32
base: master
Are you sure you want to change the base?
Conversation
addition to readme
addition to readme
addition to readme
is intended for general use. | ||
|
||
The `PromiseCAPI.js` is a promise-based version of the library | ||
which has a dependency on the Q library. While using this version a developer himself is responsible for inclusion of Q library into the project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to ease reviews (and reading of the raw markdown file), can you please configure your editor to limit the line length at less than 80 characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(this comment also meant that you need to cut those lines, I'm sure you editor has a magic shortcut for that)
In addition to the inline comments, the promise versions should be mentioned in the installation paragraph of the README |
fixes according to review
Fixes and additions implemented. |
@@ -0,0 +1,3 @@ | |||
{ | |||
"directory": "test/manual/jsRestClientBundle/Resources/public/js/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would put this file in test/manual/jsRestClientBundle (and adapt the README) as this is needed by the bundle only.
small fixes according to review
Fixed |
@dpobel, is it ok to merge this one? |
I am not 100% sure, why you needed to take out the |
Jakob, I've made it when I was trying to get rid of included Q and achieve "flexibility" you were mentioning here: #25
I can't see a way for developer to include Q into project as a manual download without using global Q variable as it is done now. And hence - "window.Q" approach. |
Ahh I see the reason now. I might have created a wrapper for the dependency, which is AMD compatible, to only use define("q", [], function() {
return window.Q;
}); I think this is a little bit cleaner, than using |
"q wrapper" approach to removing q dependency.
@jakobwesthoff, did I get you right? See my latest commit, please. |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
JIRA issue: https://jira.ez.no/browse/EZP-21963
Done.
define
call now.I'm not 100% sure, that
window.Q = require("../../node_modules/q/q");
is a nice fix, but it works and looks quite nice to me :) @jakobwesthoff, your opinion is welcome here. May be I've even chosen a wrong way to get rid of "manifested" Q dependency?