-
Notifications
You must be signed in to change notification settings - Fork 47
[Prototype] EZP-26309: Prototype the usage of REST Embedding in PlatformUI #687
base: master
Are you sure you want to change the base?
Conversation
…odel is fully responsible of the parsing
callback(error, response); | ||
return; | ||
} | ||
Y.Array.each(response.document.VersionList.VersionItem, function (versionItemHash) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: response.document.VersionList.VersionItem.forEach()
is a better, native way of doing it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the nitpicking, but what about the core feature/implementation ? (In case, you missed it, that's only a Prototype)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dpobel I'm going to check it ASAP. Very interesting approach.
var attrName, linkName; | ||
|
||
if ( L.isObject(item) ) { | ||
linkName = Y.Object.keys(item)[0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: Object.keys()
works natively everywhere
JIRA: https://jira.ez.no/browse/EZP-26309
Description
This is a prototype to use REST Embeddding (implemented in ezsystems/ezpublish-kernel#1741) in PlatformUI. It also requires ezsystems/ez-js-rest-client#79 in the JavaScript REST Client. This is done for 2 parts in PlatformUI:
Outcome
I see 2 issues in the current implementation:
Other than that, this is working well. The performance improvement on the dashboard block is really interesting and we could so the same in a lots of places! In terms of change, the big thing is in the JavaScript client where we need to change each and every method to accept a new parameter so that we can pass the custom header to request the embedding.