Development #4
Open
Development #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sveredyuk
reviewed
Jul 12, 2021
README.md
Outdated
| config/initializers/ez_status.rb | ||
| ```ruby | ||
| # Backend adapter to store all status | ||
| config.backend = Ez::Status::Store.new |
There was a problem hiding this comment.
# We need a method for capturing current monitor metrics
Ez::Status.capture! # => insert_all metrics monitors
# + add readmeThere was a problem hiding this comment.
sveredyuk
reviewed
Jul 12, 2021
app/models/ez/status/status.rb
Outdated
| self.table_name = Ez::Status.config.active_record_table_name | ||
|
|
||
| validates :name, presence: true | ||
| validates :result, presence: false |
sveredyuk
reviewed
Jul 12, 2021
lib/ez/status.rb
Outdated
| config.basic_auth_credentials = {} | ||
|
|
||
| config.active_record_table_name = nil |
There was a problem hiding this comment.
config.active_record_table_name = :ez_status_records
sveredyuk
reviewed
Jul 12, 2021
app/models/ez/status/status.rb
Outdated
|
|
||
| module Ez | ||
| module Status | ||
| class Status < ApplicationRecord |
sveredyuk
reviewed
Jul 12, 2021
| "class Create#{table_name.to_s.classify} < ActiveRecord::Migration[#{ActiveRecord::Migration.current_version}] | ||
| def change | ||
| create_table :#{table_name.to_s.underscore} do |t| | ||
| t.string :name, null: false |
There was a problem hiding this comment.
t.string :monitor_name, null: false
sveredyuk
reviewed
Jul 12, 2021
| def change | ||
| create_table :#{table_name.to_s.underscore} do |t| | ||
| t.string :name, null: false | ||
| t.string :result, null: true |
There was a problem hiding this comment.
t.boolean :result, null: true
sveredyuk
reviewed
Jul 12, 2021
| t.string :name, null: false | ||
| t.string :result, null: true | ||
| t.string :message, null: true | ||
| t.string :value, null: true |
There was a problem hiding this comment.
t.bigint :value, null: true
sveredyuk
reviewed
Jul 21, 2021
|
|
||
| ```ruby | ||
| # Order columns and which columns need to show | ||
| config.columns = [:message, :value, :result, :monitor_name,] |
| @@ -17,6 +17,11 @@ def css_for(item) | |||
| custom_css_map[scoped_item] || scoped_item | |||
| end | |||
|
|
|||
| def css_for_column_name(item) | |||
| item.gsub!(/_/, '-') | |||
| css_for(item) | |||
There was a problem hiding this comment.
css_for(item.gsub(/_/, '-'))
| context 'when default' do | ||
| before { visit '/status' } | ||
|
|
||
| it 'decorate DOM with ez-status classes' do | ||
| xit 'should default order' do |
There was a problem hiding this comment.
| before { visit '/status' } | ||
|
|
||
| xit 'should correct custom order' do | ||
| # expect(page.body).to match order |
There was a problem hiding this comment.
| around do |spec| | ||
| Ez::Status.config.columns = %i[result monitor_name] | ||
| spec.run | ||
| Ez::Status.config.columns = Ez::Status::DEFAULT_COLUMNS |
There was a problem hiding this comment.
around do |spec|
stub_config(:columns, %i[result monitor_name], &spec.run)
end
# support
def stub_config(config_key, values, &block)
prev_values = Ez::Status.config.public_send(config_key)
Ez::Status.config.public_send("#{config_key}=", values)
block.call
Ez::Status.config.public_send("#{config_key}=", prev_values)
end|
|
||
| describe 'capture!' do | ||
| it 'saves results to DB' do | ||
| expect(Ez::Status::Records.count).to be 0 |
There was a problem hiding this comment.
expect { capture }.to change { Ez::Status::Records.count }.from(0).to(2)There was a problem hiding this comment.
- check Record model data.
There was a problem hiding this comment.
expect(Ez::Status::Records.all).to match_array([
have_attributes(
monitor: '',
),
have_attributes(
monitor: '',
),
])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.