Update versions of dependencies and constraints #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cebasfu93
commented
Oct 12, 2023
•
cebasfu93
commented
- Bumped version of Pandas, pytest, pytest-cov, and ruff
- Checked that it behaves the same way (i.e. unit tests produce the same results and raise the same warnings) with Python 3.11
-
- Fixed some linting (mostly line-too-long)
eyurtsev
reviewed
Oct 12, 2023
pyproject.toml
Outdated
| @@ -16,18 +16,18 @@ classifiers = [ | |||
|
|
|||
| [tool.poetry.dependencies] | |||
| python = "^3.8.0" | |||
| pandas = "^1.5.3" | |||
| pandas = "^2.1.1" | |||
There was a problem hiding this comment.
@cebasfu93 could you replace this with ">=1.5.3" instead of bumping to 2 i don't know how many users still might be using pandas 1
This package makes minimal usage of pandas features, so I think we want to relax constraints as much as possible to accommodate more users
There was a problem hiding this comment.
Good point :)
Thanks for the quick review!
|
Update updating pyproject.toml |
eyurtsev
reviewed
Oct 13, 2023
eyurtsev
changed the title
|
Is there anything else you would like me to address? 😇 |
|
All good thanks @cebasfu93 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.