Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native Image Scale #781

Merged
merged 3 commits into from
Apr 21, 2022
Merged

Native Image Scale #781

merged 3 commits into from
Apr 21, 2022

Conversation

hotbott
Copy link
Contributor

@hotbott hotbott commented Dec 2, 2021

toNativeImage() creates a blurry image on Retina devices.

According to the reference
The scale factor to apply to the bitmap. If you specify a value of 0.0, the scale factor is set to the scale factor of the device’s main screen.

Adressing issues #752, #686 and PRs #780, #748

@hotbott
Copy link
Contributor Author

hotbott commented Jan 14, 2022

@ystrot, @f3dm76 please review

@hotbott
Copy link
Contributor Author

hotbott commented Feb 10, 2022

is this project still active?

@gunhansancar
Copy link

@hotbott Thanks for the PR. I wish the owners accept the changes soon, as I tried to create the same functionality without this PR but most of the used classes are not open so stuck for now. Maybe I can add this as a static framework 🤷

@VineFiner
Copy link

@f3dm76 please review

@ystrot ystrot merged commit 29ec199 into exyte:master Apr 21, 2022
@VineFiner
Copy link

@ystrot, @f3dm76 please review

Hello, is this default Scale 0.0 suitable?

@ystrot
Copy link
Member

ystrot commented Apr 21, 2022

Looks like it's even better than previous value = 1 : https://developer.apple.com/documentation/uikit/1623912-uigraphicsbeginimagecontextwitho

@VineFiner
Copy link

Looks like it's even better than previous value = 1 : https://developer.apple.com/documentation/uikit/1623912-uigraphicsbeginimagecontextwitho

Okay thank you.

yuzhiyou1990 added a commit to yuzhiyou1990/Macaw that referenced this pull request Sep 20, 2022
@yuzhiyou1990
Squashed commit of the following:
61a9fd3 
commit 9c087ea
Author: Yuri Strot <[email protected]>
Date:   Sun May 15 18:42:57 2022 +0700

    Update README.md

commit a3ddf65
Author: Yuri Strot <[email protected]>
Date:   Sun May 15 18:32:07 2022 +0700

    Add deprecation image

commit 29ec199
Merge: d508348 9797fb0
Author: Yuri Strot <[email protected]>
Date:   Thu Apr 21 16:59:18 2022 +0700

    Merge pull request exyte#781 from hotbott/master

    Native Image Scale

commit 9797fb0
Author: Sebastian Bott <[email protected]>
Date:   Thu Dec 2 17:42:55 2021 +0100

    Bump version

commit 96e4900
Author: Sebastian Bott <[email protected]>
Date:   Thu Dec 2 17:42:32 2021 +0100

    Fix native image scale

commit 197903c
Author: Sebastian Bott <[email protected]>
Date:   Thu Dec 2 17:42:08 2021 +0100

    Add render dispose

commit d508348
Author: Alisa Mylnikova <[email protected]>
Date:   Fri Oct 29 15:04:40 2021 +0700

    Bump version

commit 5cde520
Merge: f9c0972 7b54dda
Author: Yuri Strot <[email protected]>
Date:   Fri Oct 29 15:01:43 2021 +0700

    Merge pull request exyte#779 from exyte/fix/smooth-group-animation

    fix unsmooth group animation

commit 7b54dda
Author: Mark Goldin <[email protected]>
Date:   Fri Oct 29 14:57:38 2021 +0700

    fix unsmooth group animation

commit f9c0972
Author: Alisa Mylnikova <[email protected]>
Date:   Fri Oct 8 17:23:41 2021 +0700

    Bump version

commit 931cbdb
Merge: b332010 26271bc
Author: Yuri Strot <[email protected]>
Date:   Fri Oct 8 16:45:34 2021 +0700

    Merge pull request exyte#773 from exyte/fix-tests-unwrapping

    Fix image unwrapping, some crashes

commit 26271bc
Merge: 6415858 b332010
Author: Yuri Strot <[email protected]>
Date:   Fri Oct 8 16:45:19 2021 +0700

    Merge branch 'master' into fix-tests-unwrapping

commit b332010
Merge: 2b406e5 dfcfdbe
Author: Yuri Strot <[email protected]>
Date:   Fri Oct 8 16:43:17 2021 +0700

    Merge pull request exyte#772 from exyte/769-SWXMLHash-Compatibility

    exyte#769 SWXMLHash Compatibility

commit 6415858
Author: Daniil Manin <[email protected]>
Date:   Tue Oct 5 14:09:55 2021 +0700

    Update renderToImage method, optional image

commit d5ae291
Author: Daniil Manin <[email protected]>
Date:   Tue Oct 5 14:06:48 2021 +0700

    Fix test's method - to native image, add throw CommonError.invalidImageContext

commit dfcfdbe
Author: Daniil Manin <[email protected]>
Date:   Mon Oct 4 17:58:51 2021 +0700

    Update indents

commit cc7513b
Author: Daniil Manin <[email protected]>
Date:   Mon Oct 4 17:50:17 2021 +0700

    exyte#769 Update SWXMLHash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f3dm76 f3dm76 f3dm76 approved these changes

@ystrot ystrot ystrot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hotbott @gunhansancar @VineFiner @ystrot @f3dm76