Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button block consolidation with new button element support #67

Closed
wants to merge 1 commit into from

Conversation

colorful-tones
Copy link
Contributor

❗This requires Gutenberg 13.4 or later to be active. We may want to merge this for next WP minor release?❗

Please see: WordPress/gutenberg#40260 for more info.

Addresses #64

@colorful-tones colorful-tones self-assigned this Jun 13, 2022
@colorful-tones colorful-tones requested a review from richtabor June 13, 2022 20:14
@colorful-tones colorful-tones added enhancement New feature or request question Further information is requested labels Jun 13, 2022
@richtabor
Copy link
Contributor

Should we keep the old CSS in for the meantime?

@colorful-tones
Copy link
Contributor Author

Should we keep the old CSS in for the meantime?

It is worth a quick test. Then we would have to make a note to remove the CSS after the next minor release. So, either approach offers maintenance. 🤔

@richtabor
Copy link
Contributor

Closing for now to get a better idea of how to tackle this moving forward.

@richtabor richtabor closed this Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants