update copyright #1701
Open
update copyright #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
I like the idea! Here are some suggestions:
- We should respect the previous copyright and add additional lines when is required, like in this file:
/*! * express * Copyright(c) 2009-2013 TJ Holowaychuk * Copyright(c) 2013 Roman Shtylman * Copyright(c) 2014-2015 Douglas Christopher Wilson * MIT Licensed */ - 2024 is not the correct year, probably is 2016 (see) back then it was the Node.js foundation, and just recently OpenJS foundation (2019? see). But not sure if the copyright is now owned by them or by the project (cc: @wesleytodd ) 🤔
|
As I understand it, the copyright would belong to OpenJS. If they recommend adding the following text in the footer:
ref: https://github.com/openjs-foundation/artwork#copyright-notices-for-project-website-footers and maybe the year should be from 2019 to the present, perhaps it would be good to clarify this in the CPC? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The copyright of the site is updated. I’m not sure what sense it makes to add them to the files, but it’s good to update it.
As suggested in #1698 (comment)
cc: @expressjs/express-tc