Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix menu text align #1699

Open
wants to merge 2 commits into
base: gh-pages
Choose a base branch
from

Conversation

bjohansebas
Copy link
Member

Fix a bug that was accidentally introduced in #1670

before:
image

after:
image

@bjohansebas bjohansebas requested a review from a team November 25, 2024 02:06
Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit d16b5bc
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/674618b81afb810008052bcc
😎 Deploy Preview https://deploy-preview-1699--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chrisdel101
Copy link
Contributor

I like the new way with the links centered, better than original left-positioned. But it's buggy.
Any chance of just fixing up this method? I saw this in the PR and liked it, but missed the bugginess.
Screenshot 2024-11-25 083032

@bjohansebas
Copy link
Member Author

I also liked that it was centered, so I’m going to center the menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants