Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add language picker #1695

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

feat: add language picker #1695

wants to merge 1 commit into from

Conversation

cengizcmataraci
Copy link
Contributor

Adding language picker to header
by #1687

@netlify Netlify
Copy link

netlify bot commented Nov 23, 2024 •
edited
Loading

✅ Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 2685347
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/674269051c038b000812635c
😎 Deploy Preview https://deploy-preview-1695--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bjohansebas bjohansebas requested a review from a team November 24, 2024 00:00
bjohansebas
bjohansebas reviewed Nov 24, 2024
View reviewed changes
Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we don't want it to be removed in mobile until it really breaks the mobile responsiveness.

With the selector, I think this part of the page can be removed now.
image

I really love that this is being added.

@cengizcmataraci
Copy link
Contributor Author

I don't add the picker in the mobile, but I'll add it and remove the language part if you folks want. And I also like the picker. 😄

@carlosstenzel
Copy link
Contributor

@cengizcmataraci
good job ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjohansebas bjohansebas bjohansebas left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cengizcmataraci @carlosstenzel @bjohansebas