Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Erase a sentence about discussion #1630

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

LuiGeeDev
Copy link
Contributor

In English version, the sentence 'You can read the discussion that led to the deprecation of the app.del function here.' is deleted 9 years ago(commit), but it still exists in a Korean migration guide. So this commit erases it.

Copy link

netlify bot commented Sep 24, 2024

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit a55755c
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/66f219ab775def00089d00e5
😎 Deploy Preview https://deploy-preview-1630--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation and the context in the PR @LuiGeeDev! ❤️

@crandmck crandmck merged commit 3555981 into expressjs:gh-pages Sep 30, 2024
7 of 8 checks passed
@LuiGeeDev LuiGeeDev deleted the patch-1 branch October 7, 2024 07:16
chrisdel101 pushed a commit to chrisdel101/expressjs.com that referenced this pull request Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants