Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat - add support and blog in menu #1615

Open
wants to merge 5 commits into
base: gh-pages
Choose a base branch
from
Open

feat - add support and blog in menu #1615

wants to merge 5 commits into from

Conversation

carlosstenzel
Copy link
Contributor

@carlosstenzel carlosstenzel commented Sep 13, 2024 •
edited
Loading

Add in menu

  • page support
  • page blog

@netlify Netlify
Copy link

netlify bot commented Sep 13, 2024 •
edited
Loading

✅ Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit f0a074a
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/675cae2be977870008d6cfa4
😎 Deploy Preview https://deploy-preview-1615--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bjohansebas bjohansebas requested a review from a team October 21, 2024 01:19
juliogarciape
juliogarciape reviewed Oct 21, 2024
View reviewed changes
Copy link
Member

@juliogarciape juliogarciape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's good to add a new tab, but if there is no translation for each content on the blog or support page, I think it's unnecessary.

@carlosstenzel
Copy link
Contributor Author

@bjohansebas
what do you think ?

@bjohansebas
Copy link
Member

I think this would help maintain consistency between pages even if the content is not translated

@bjohansebas
Copy link
Member

I would prefer to launch this PR when #1568 is approved, as adding this PR may break mobile responsiveness.

@bjohansebas bjohansebas mentioned this pull request Nov 24, 2024
Open
@bjohansebas
Copy link
Member

hi @carlosstenzel, Can you add the support page to each of the languages, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliogarciape juliogarciape juliogarciape left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlosstenzel @bjohansebas @juliogarciape