-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use admonitions in several pages #1595
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The action (check-translation) is failing due to your repository permission not allowing writing, as discussed in other PRs |
Add manually to test if the action works '{"labels":["requires-translation-es","requires-translation-fr","requires-translation-it","requires-translation-ja","requires-translation-ko","requires-translation-pt-br","requires-translation-ru","requires-translation-sk","requires-translation-zh-cn","requires-translation-zh-tw"]}', |
The permissions of my repository don't affect anything in the PRs; the rules in this repository do. That's why in this PR (#1588) it works fine, because @crandmck was the one who opened it. |
Please resolve the merge conflicts and we can land this, thanks! |
@crandmck done |
There were several places where the use of admonitions is still not applied; this greatly improves the guidance in the documentation.