-
-
Notifications
You must be signed in to change notification settings - Fork 220
Exposed verify token. Fixes #43. #82
base: master
Are you sure you want to change the base?
Conversation
Please add some tests and documentation :) |
Done! |
test/test.js
Outdated
@@ -323,6 +323,63 @@ describe('csurf', function () { | |||
}) | |||
}) | |||
|
|||
describe.only('req.verifyToken()', function () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .only disabled all other tests. Please just use describe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I had that in there for my own tests. I'll remove it.
Thanks, looking good! The tests are failing in Node.js 0.12 and up, it looks like. Seems like just an issue in the tests themselves, I would guess. |
Awesome, I'll take a look at it in 0.12 and see if I can find out what's going on. |
@YourDeveloperFriend @dougwilson Any update on the status of this PR? Tests seem to be passing and code approved - would be great to have access to this functionality without having to use a forked version. Happy to contribute if there's more work to be done. |
Hi @camacho , sorry, I didn't realize the issue was addressed, as there was no follow-up comment after "I'll take a look" and GitHub provides no notifications for when new commits are pushed to a PR, so it completely dropped off my radar. |
no worries @dougwilson - is there anything additional that needs to be done with this PR? |
This would be great to get implemented.. would be nice to base64 encode/decode or encrypt tokens during use. |
Is there anything I could do to help move this along? I was about to fork myself to build this exact feature. I would very much prefer to be able to use the upstream library. |
It was never merged? |
AFAIK there's nothing on my end that needs to happen. Please let me know if there's something that's missing from my PR. |
How about getting this merged in. It has been 2 years... |
👍 For this feature. My use case is the same as #43 in that I'm validating |
👍 for this. I also want to use csurf to validate |
For anyone needing csurf in the context of an OAuth callback you can use the following as a middleware:
|
No description provided.