Skip to content
This repository has been archived by the owner on Aug 21, 2022. It is now read-only.

add showStack option #13

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jonchurch
Copy link
Member

This feature has been requested a few times and attempted in several PRs such as:

#1 #2 #5 #12

Most recently something like this was requested in #11

I read the feedback from other PRs and created one that I think accomplishes the requests I saw there, such as setting the option as a boolean.

While working on this I realized that the production flag internally in the module is set at the time of require, which necessitated some tricky work in the tests. I created two new sets of tests for regression testing of this feature. They clear the require cache for this module before setting the NODE_ENV value, so we can properly test the behavior of hiding/showing stack traces based on the environment.

@coveralls
Copy link

coveralls commented Feb 1, 2020

Coverage Status

Coverage remained the same at 100.0% when pulling 9479352 on jonchurch:show-stack-option into df765a5 on expressjs:master.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants