datetime custom format

[expobrain]

• Add tests for all Marshmallow DateTime() formats
• Add tests for all Marshmallow Date() formats
• Fixed generating Marshmallow DateTime formats
• Fixed generating Marshmallow Date formats

Summary by CodeRabbit

• New Features

  • Introduced a new method to handle Date fields in API specifications, enhancing support for OpenAPI properties.

• Bug Fixes

  • Streamlined logic for handling DateTime fields, improving consistency and reliability.

• Tests

  • Consolidated and parameterized test functions for datetime and date properties, enhancing test coverage and maintainability.

[coderabbitai]

Walkthrough

The changes introduce a new method, date2properties, for converting marshmallow Date fields into OpenAPI properties, alongside modifications to the existing datetime2properties method. The test structure has been updated to consolidate datetime and date tests into parameterized functions, enhancing efficiency and maintainability. This includes new tests for various date formats, ensuring comprehensive coverage for both datetime and date properties in the API specification.

Changes

Files	Change Summary
src/apispec/ext/marshmallow/field_converter.py	Added date2properties method for handling Date fields; modified datetime2properties for simplified logic.
tests/test_ext_marshmallow_field.py	Consolidated datetime tests into test_datetime2property; added test_date2property for testing various date formats.

Poem

🐇 In fields of code, a change took flight,
With dates and times now shining bright.
A method new, a test so neat,
In harmony, they dance and greet.
Let's hop with joy, for all to see,
A brighter spec for you and me! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

Early access features: disabled

We are currently testing the following features in early access:

• Anthropic claude-3-5-sonnet for code reviews: Anthropic claims that the new Claude model has stronger code understanding and code generation capabilities than their previous models. Note: Our default code review model was also updated late last week. Please compare the quality of the reviews between the two models by toggling the early access feature.

Note:

• You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.
• Please join our Discord Community to provide feedback and report issues on the discussion post.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between bfd20e6 and 03004c9.

Files selected for processing (2)

• src/apispec/ext/marshmallow/field_converter.py (3 hunks)
• tests/test_ext_marshmallow_field.py (2 hunks)

Additional comments not posted (4)

tests/test_ext_marshmallow_field.py (2)

460-508: LGTM!

The parameterized test approach is an effective way to test multiple datetime formats. The test cases cover a good range of formats and the expected outputs are clearly defined.

---

602-632: LGTM!

The parameterized test for date formats is well-structured and covers the essential formats. The expected outputs are clearly defined for each test case.

src/apispec/ext/marshmallow/field_converter.py (2)

598-630: LGTM!

The new date2properties method looks good. It handles the conversion of marshmallow Date fields into OpenAPI properties correctly, considering different formats and metadata patterns.

---

Line range hint 548-596: LGTM!

The changes to the datetime2properties method look good. Removing the unnecessary type check for marshmallow.fields.Date simplifies the code without affecting the functionality.