-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSC/ECE 517 Fall 2024 - E2488. Reimplement add TA #72
Open
MakarandPundlik
wants to merge
20
commits into
expertiza:main
Choose a base branch
from
MakarandPundlik:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
147c947
Updated README.md added contributors name
MakarandPundlik 159ca63
Added npm install command
MakarandPundlik 52d4f29
UI enhancements to the TA and Course page
65421d9
resolved a bug by adding select TA to the final array and removed it …
MakarandPundlik fbf7ba4
Merge pull request #5 from MakarandPundlik/makarand_features
AnuragGorkar 36e0219
Merge pull request #1 from MakarandPundlik/manage_ta_page
MakarandPundlik 8626591
added unit test cases for columns
MakarandPundlik 104268a
added unit test cases for coursecolumns
MakarandPundlik d3da1da
added test cases for column button
MakarandPundlik f81a2ad
Merge pull request #6 from MakarandPundlik/makarand_unit_tests
MakarandPundlik bd54b4e
Added select feature to Add TA drop down
d6fc810
Merge pull request #9 from MakarandPundlik/8-add-search-feature-for-s…
AnuragGorkar 57bc5e4
Fetch students as well as TAs in the Add TA page
Rutvik2598 909c0c3
Merge pull request #10 from MakarandPundlik/3-fetch-all-students-and-…
Rutvik2598 8108d86
Added permission check before rendering add TA button
c525ad5
Merge pull request #13 from MakarandPundlik/11-admin-only-access-to-a…
AnuragGorkar 2138f9a
Removed contributor names
MakarandPundlik 59e8b6e
Code cleanup
e0cf5da
Instructor can also add TA other than Admin
Rutvik2598 ef6fd6d
Merge pull request #14 from MakarandPundlik/instructor_can_add_ta
AnuragGorkar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
import React from "react"; | ||
import { Button, OverlayTrigger, Tooltip } from "react-bootstrap"; | ||
|
||
/** | ||
* @author Rutvik Kulkarni on Nov, 2024 | ||
*/ | ||
|
||
interface ColumnButtonProps { | ||
id: string; | ||
label?: string; | ||
tooltip?: string; | ||
variant: string; | ||
size?: "sm" | "lg"; // Matches React-Bootstrap Button prop | ||
className?: string; | ||
onClick: () => void; | ||
icon: React.ReactNode; | ||
} | ||
|
||
const ColumnButton: React.FC<ColumnButtonProps> = (props) => { | ||
const { | ||
id, | ||
label, | ||
tooltip, | ||
variant, | ||
size, | ||
className, | ||
onClick, | ||
icon, | ||
} = props; | ||
|
||
const displayButton = ( | ||
<Button | ||
variant={variant} | ||
size={size} | ||
className={className} | ||
onClick={onClick} | ||
aria-label={label} | ||
> | ||
{icon} | ||
</Button> | ||
); | ||
|
||
if (tooltip) { | ||
return ( | ||
<OverlayTrigger | ||
placement="top" | ||
overlay={<Tooltip id={`${id}-tooltip`}>{tooltip}</Tooltip>} | ||
> | ||
{displayButton} | ||
</OverlayTrigger> | ||
); | ||
} | ||
|
||
return displayButton; | ||
}; | ||
|
||
export default ColumnButton; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove contibutors from here, since its a common readme file.