Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2478: fix for questionnaire UI #69

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

bhandariprerak
Copy link

No description provided.

@vihar2712
Copy link

For the phase 1, we worked on these improvements:

  • Responsive UI: Reorganize frontend layout for intuitive, mobile-friendly, and accessible design.
  • Code Clarity: Use clear, descriptive names for variables and methods. Add comprehensive comments for easier understanding and maintenance.
  • Efficient HTML Management: Implement partials to reduce redundancy and follow the DRY principle.
  • Robust Testing: Expand jest-dom tests to cover all functionality, ensuring reliability and adaptability.

What exactly was improved inside Edit Questionnaire page:

  1. Changed variable names which were ambiguous. For example: variable named 'a' was defined for download link which was refactored to downloadLink ; seq was changed to sequence; state variables for review, modal etc... increasing the readability.

  2. Also, earlier unnecessary repeating html tags were written increasing the code length which was made shorter by implementing array and rendering it efficiently.

  3. Added comments inside the file where necessary describing the code and what it expects to render making it more accessible to other contributors.

  4. Added several test cases for the Edit Questionnaire page which involves testing the events like editing the query, adding new question, rendering initial data, etc..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants