E 2470: Reimplement the grades_controller Pull request 2 (just the factory changes, as requested) #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a separate pr This was made a different pr in order to help facilitate easier operation from the ts. This change is unlikely to have negative outcomes or side effects as it is just a factory suite to facilitate future improvements to the system.
jphulse
changed the title
|
If the other pr labeled E2470 is approved do not approve this one as there may be a merge conflict, instead check that one and if it is rejected this can be used as a backup to incorporate the factory improvements for better testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional PR to facilitate the movement of the factories.rb file which has been vastly expanded to incorporate almost every model in the system in order to prevent future DRY violations from occurring within the test suite where possible. This will also make it much easier to test more complex controllers as the system grows.