-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2470 reimplement grades_controller.rb #123
Open
jphulse
wants to merge
42
commits into
expertiza:main
Choose a base branch
from
jphulse:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied the grades_controller.rb file from the main Expertiza repository to begin refactoring soon
Copied the routes for grades making sure that the formatting looked appropriate given the other file contents and routes.
Grades controller dev
…ller_dev's copy The other dev branch is effectively dead, and this is the new branch so this should be considered a SETUP commit
…pooint for action_allowed, and started the spec file
- Added/Updated Helpers - Revised view/view_team methods - Organized some additional statements
…ier grade operations with less clutter
Debugging statements put into test code to figure out login issues.
…method, and added grade_for_submission and comment_for_submission to the Teams table in the db
…d fixed minor style errors
…nly focused on adding clarity to the comments of the helper methods
Merging dev into main to construct final PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for E2470 which is to reimplement the grades_controller.rb
Current project status: STARTED