[BUGFIX][IN23-251] Ported obsolete/deprecated install- and upgradesch…

…ema to db_schema.xml and db_schema_whitelist.json. FILE: /data/web/magento2/lib/experius/module-emailcatcher/Setup/UpgradeSchema.php --------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | UpgradeSchema scripts are obsolete. Please use declarative schema approach in module's etc/db_schema.xml file --------------------------------------------------------------------------------------------------------------------------- FILE: /data/web/magento2/lib/experius/module-emailcatcher/Setup/InstallSchema.php --------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------- 1 | ERROR | InstallSchema scripts are obsolete. Please use declarative schema approach in module's etc/db_schema.xml file ---------------------------------------------------------------------------------------------------------------------------
experius · Oct 25, 2023 · ab23d22 · ab23d22
1 parent 2e84e74
commit ab23d22
Show file tree

Hide file tree

Showing 4 changed files with 39 additions and 154 deletions.
diff --git a/Setup/InstallSchema.php b/Setup/InstallSchema.php
diff --git a/Setup/UpgradeSchema.php b/Setup/UpgradeSchema.php
diff --git a/etc/db_schema.xml b/etc/db_schema.xml
@@ -1,16 +1,22 @@
 <?xml version="1.0"?>
-<schema xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Setup/Declaration/Schema/etc/schema.xsd">
-  <table name="experius_emailcatcher" resource="default" engine="innodb" comment="experius_emailcatcher">
-    <column xsi:type="int" name="emailcatcher_id" padding="10" unsigned="true" nullable="false" identity="true" comment="Entity ID"/>
-    <column xsi:type="text" name="recipient" nullable="true" comment="To Email Address"/>
-    <column xsi:type="text" name="sender" nullable="true" comment="From Email Address"/>
-    <column xsi:type="text" name="subject" nullable="true" comment="Subject"/>
-    <column xsi:type="text" name="body" nullable="true" comment="Email Body"/>
-    <column xsi:type="text" name="template_identifier" nullable="true" comment="Email Template Identifier"/>
-    <column xsi:type="datetime" name="created_at" on_update="false" nullable="true" comment="Created At"/>
-    <column xsi:type="int" name="store_id" padding="11" unsigned="false" nullable="true" identity="false" comment="Store Id"/>
-    <constraint xsi:type="primary" referenceId="PRIMARY">
-      <column name="emailcatcher_id"/>
-    </constraint>
-  </table>
+<schema xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+        xsi:noNamespaceSchemaLocation="urn:magento:framework:Setup/Declaration/Schema/etc/schema.xsd">
+    <table name="experius_emailcatcher" resource="default" engine="innodb" comment="experius_emailcatcher">
+        <column xsi:type="int" name="emailcatcher_id" padding="10" unsigned="true" nullable="false" identity="true"
+                comment="Entity ID"/>
+        <column xsi:type="text" name="recipient" nullable="true" comment="To Email Address"/>
+        <column xsi:type="text" name="sender" nullable="true" comment="From Email Address"/>
+        <column xsi:type="text" name="subject" nullable="true" comment="Subject"/>
+        <column xsi:type="text" name="body" nullable="true" comment="Email Body"/>
+        <column xsi:type="text" name="template_identifier" nullable="true" comment="Email Template Identifier"/>
+        <column xsi:type="datetime" name="created_at" on_update="false" nullable="true" comment="Created At"/>
+        <column xsi:type="int" name="store_id" padding="11" unsigned="false" nullable="true" identity="false"
+                comment="Store Id"/>
+        <constraint xsi:type="primary" referenceId="PRIMARY">
+            <column name="emailcatcher_id"/>
+            <column name="emailcatcher_id"/>
+        </constraint>
+        <column xsi:type="text" name="to" nullable="true" comment="To Email Address"/>
+        <column xsi:type="text" name="from" nullable="true" comment="From Email Address"/>
+    </table>
 </schema>
diff --git a/etc/db_schema_whitelist.json b/etc/db_schema_whitelist.json
@@ -0,0 +1,19 @@
+{
+    "experius_emailcatcher": {
+        "column": {
+            "emailcatcher_id": true,
+            "recipient": true,
+            "sender": true,
+            "subject": true,
+            "body": true,
+            "template_identifier": true,
+            "created_at": true,
+            "store_id": true,
+            "to": true,
+            "from": true
+        },
+        "constraint": {
+            "PRIMARY": true
+        }
+    }
+}