[TASK] removed unnecessary mail class, switch to mailTransportFactory

experius · Dec 10, 2018 · 7ecbfaf · 7ecbfaf
1 parent 1e61003
commit 7ecbfaf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 86 deletions.
diff --git a/Mail/Transport.php b/Mail/Transport.php
diff --git a/Model/Mail.php b/Model/Mail.php
@@ -9,16 +9,16 @@ class Mail
 
     protected $emailCatcherFactory;
 
-    protected $transport;
+    protected $mailTransportFactory;
 
     public function __construct(
         \Magento\Framework\Mail\Message $messageFactory,
         \Experius\EmailCatcher\Model\EmailcatcherFactory $emailcatcherFactory,
-        \Experius\EmailCatcher\Mail\Transport $transport
+        \Magento\Framework\Mail\TransportInterfaceFactory $transportInterfaceFactory
     ) {
         $this->messageFactory = $messageFactory;
         $this->emailCatcherFactory = $emailcatcherFactory;
-        $this->transport = $transport;
+        $this->mailTransportFactory = $transportInterfaceFactory;
     }
 
     public function sendMessage($emailCatcherId, $alternativeToAddress)
@@ -38,7 +38,8 @@ public function sendMessage($emailCatcherId, $alternativeToAddress)
         $message->setBodyHtml($emailCatcher->getBody());
         $message->setSubject(mb_encode_mimeheader($emailCatcher->getSubject()));
 
-        $this->transport->setMessage($message);
-        $this->transport->sendMessage();
+        $mailTransport = $this->mailTransportFactory->create(['message' => clone $message]);
+
+        $mailTransport->sendMessage();
     }
 }