Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Touch support #27

Draft
wants to merge 3 commits into
base: experiment-main
Choose a base branch
from

Conversation

GuestSneezeOSDev
Copy link

@GuestSneezeOSDev GuestSneezeOSDev commented Jan 2, 2025

What this pull request does:

  • Add Touch support
  • FULL Android Support (requires installation of vs-android which can be found in src/android)

@luttje
Copy link
Collaborator

luttje commented Jan 2, 2025

Very cool, thanks for your contribution! I won't merge this just yet, I want to take my time to test this and don't have that right now. But the prospect of being able to run a Source Engine game on Android is fun!

When I test this in the future, I'll be removing that vs-android_launch.exe. I'd rather not have too many exe files in this project. Instead we should direct users to how they can install it from official sources.

Thanks again and good luck on your own project!

@luttje luttje self-requested a review January 2, 2025 21:14
@GuestSneezeOSDev
Copy link
Author

GuestSneezeOSDev commented Jan 2, 2025 via email

@GuestSneezeOSDev
Copy link
Author

Very cool, thanks for your contribution! I won't merge this just yet, I want to take my time to test this and don't have that right now. But the prospect of being able to run a Source Engine game on Android is fun!

When I test this in the future, I'll be removing that vs-android_launch.exe. I'd rather not have too many exe files in this project. Instead we should direct users to how they can install it from official sources.

Thanks again and good luck on your own project!

Alright I'll be resolving this issue soon. I will also be create a custom .apk file for running Source Engine games

echo "It can be located here -> http://www.gavpugh.com/downloads/vs-android-0.964.zip"
sleep 5
echo "Editing client to support Android."
${SRCDIR}/game/client/client.vcxproj << EOF
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know there is a way to improve this shitty code but I am too lazy to this right now.

@luttje
Copy link
Collaborator

luttje commented Jan 8, 2025

Thanks again for this contribution!

After reflecting on this for a bit I've decided its too early to support another platform. Maintaining that code, and having to test it, is something I'm just not looking forward to. Besides that support for the Windows platform still requires a lot of work and the same goes for Linux (server) platform support.

So sorry, but I won't be merging this anytime soon. I hope you can see that I'm not ungrateful for your contribution. I am simply trying to make it easier for me to come back and work on this project in the future.

That said I do think this PR is helpful to others, so I'll change this PR to a draft and leave it open for others to fork.

@luttje luttje marked this pull request as draft January 8, 2025 18:16
@luttje luttje removed their request for review January 8, 2025 18:16
@GuestSneezeOSDev
Copy link
Author

Thanks again for this contribution!

After reflecting on this for a bit I've decided its too early to support another platform. Maintaining that code, and having to test it, is something I'm just not looking forward to. Besides that support for the Windows platform still requires a lot of work and the same goes for Linux (server) platform support.

So sorry, but I won't be merging this anytime soon. I hope you can see that I'm not ungrateful for your contribution. I am simply trying to make it easier for me to come back and work on this project in the future.

That said I do think this PR is helpful to others, so I'll change this PR to a draft and leave it open for others to fork.

Alright.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants