Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync tests #220

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Sync tests #220

merged 1 commit into from
Jun 18, 2024

Conversation

keiravillekode
Copy link
Contributor

We sync the tests for

  • change
  • knapsack
  • roman-numerals

We sync the tests for
- change
- knapsack
- roman-numerals
Copy link

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

Copy link
Contributor

@1ethanhansen 1ethanhansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should knapsack's v test code have a corresponding new test?

@keiravillekode
Copy link
Contributor Author

should knapsack's v test code have a corresponding new test?

No. The replacement test in problem-specifications merely replaced {} with [] in the JSON.

    {
      "uuid": "a4d7d2f0-ad8a-460c-86f3-88ba709d41a7",
      "description": "no items",
      "property": "maximumValue",
      "input": {
        "maximumWeight": 100,
        "items": {}
      },
      "expected": 0
    },
    {
      "uuid": "3993a824-c20e-493d-b3c9-ee8a7753ee59",
      "reimplements": "a4d7d2f0-ad8a-460c-86f3-88ba709d41a7",
      "description": "no items",
      "property": "maximumValue",
      "input": {
        "maximumWeight": 100,
        "items": []
      },
      "expected": 0
    },

@1ethanhansen
Copy link
Contributor

should knapsack's v test code have a corresponding new test?

No. The replacement test in problem-specifications merely replaced {} with [] in the JSON.

    {
      "uuid": "a4d7d2f0-ad8a-460c-86f3-88ba709d41a7",
      "description": "no items",
      "property": "maximumValue",
      "input": {
        "maximumWeight": 100,
        "items": {}
      },
      "expected": 0
    },
    {
      "uuid": "3993a824-c20e-493d-b3c9-ee8a7753ee59",
      "reimplements": "a4d7d2f0-ad8a-460c-86f3-88ba709d41a7",
      "description": "no items",
      "property": "maximumValue",
      "input": {
        "maximumWeight": 100,
        "items": []
      },
      "expected": 0
    },

Gotcha! Thanks

@1ethanhansen 1ethanhansen merged commit 3c69e3a into exercism:main Jun 18, 2024
5 checks passed
@keiravillekode keiravillekode deleted the sync-tests branch June 18, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants