Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[List Methods/Chaitana's Colossal Coaster]: Added Queue Validation Tests & Instructions Note #3825

Merged

Conversation

BethanyG
Copy link
Member

Per forum discussion.

Not exactly a fan of all the queue checks, but we are going to run a little experiment to see if it increases or decreases complains and or completions.

Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@BethanyG
Copy link
Member Author

@ErikSchierboom -- is it OK to merge this, or should I keep it open for you?

@ErikSchierboom
Copy link
Member

@BethanyG This does change the test file so that would re-queue all existing solutions. Is that necessary, or could this be merged with [no important files changed]?

@BethanyG
Copy link
Member Author

It does change the test file to add more test scenarios & validate that the passed-in lists are mutated - so as a test to make sure the bot fired, it works.

Because it adds tests, my first reaction would be to re-test solutions. But this exercise has a little over 16k completions, and I believe the majority of solutions would still pass the new tests. So I would probably apply [no important files changed] here.

@ErikSchierboom
Copy link
Member

Ah, I missed that this was also a test! Sorry.

So I would probably apply [no important files changed] here.

Agreed.

@BethanyG BethanyG merged commit bba3d80 into exercism:main Nov 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants