-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yacht: add exercise #807
yacht: add exercise #807
Conversation
@verdammelt Hi! Could we merge it, or should I change something? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good start... but I would like to discuss some small changes to make it, IMHO, better.
Sorry it took me so long to respond. But see my comments above. |
@verdammelt Thank you for review. I will improve my solution. |
@verdammelt Is it ok now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is looking good, but using keywords rather than strings would be better.
@verdammelt Now categories are keywords, and there is a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking the time for all the updates.
Thank you for all your reviews! |
Summary
For #48in24. I used the Clojure implementation as a reference.
Checklist
./bin/configlet generate
to ensure all documents are properly generated.