Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate Roswell #764

Merged
merged 6 commits into from
Nov 16, 2023
Merged

Incorporate Roswell #764

merged 6 commits into from
Nov 16, 2023

Conversation

glennj
Copy link
Contributor

@glennj glennj commented Nov 6, 2023

  • INSTALLATION and TESTS docs updated.
  • exercises/shared/.docs/tests.md updated (used to create HELP.md for downloads)
  • Updated exercise generator script to create test launcher scripts.
  • Added launcher scripts to all exercises

You might want to review this by commit, the "Add launcher scripts to all exercises" commit is large and repetitive.

Closes #759

@glennj
Copy link
Contributor Author

glennj commented Nov 7, 2023

A note: the bulk of bin/lisp_exercise_generator.py can be replaced by a single call to bin/configlet -- create the director structure, create the docs/meta/tests.toml. An example, https://github.com/exercism/8th/blob/main/bin/add-exercise

@verdammelt
Copy link
Member

Sorry but I am not a fan of adding two shells scripts to every exercise. I don't think this use case is so used that it warrants the additional maintenance load.

I think editing in the web editor, for better or worse, is the main use case. The secondary use case is working in an editor and REPL.

I don't mind adding instructions on how to use roswell for others like you that wish to run the exercises from the command line, but I don't want to maintain a two shell scripts per exercise (one of which, the powershell script, I cannot even run).

Sorry if I didn't realize that this was the direction you were going; if I had realized that I would have cut it off sooner.

@verdammelt
Copy link
Member

A note: the bulk of bin/lisp_exercise_generator.py can be replaced
by a single call to bin/configlet -- create the director structure,
create the docs/meta/tests.toml. An example,
https://github.com/exercism/8th/blob/main/bin/add-exercise

Ah, this is good to know. I regret the inclusion of the python script (I had attempted to keep a "rule" of using Common Lisp for as much of the tooling as possible). It is also not a script I use. So with both those points I think it is great that we could remove it.

I'll add an issue and work on that some time later.

@glennj
Copy link
Contributor Author

glennj commented Nov 7, 2023

I don't mind adding instructions on how to use roswell for others like you that wish to run the exercises from the command line, but I don't want to maintain a two shell scripts per exercise

OK, no problem. I'll remove those, and revamp the docs.

Sorry if I didn't realize that this was the direction you were going; if I had realized that I would have cut it off sooner.

That's perfectly OK. This stuff is fun. I didn't mean to cause you undue stress with the massive commit. My apologies for that.

[removing the exercise generate script]

Do you want me to do that while I'm in here?

@verdammelt
Copy link
Member

OK, no problem. I'll remove those, and revamp the docs.

Excellent - thanks.

I didn't mean to cause you undue stress with the massive commit

No problem. I understand "this stuff is fun" feeling :D .

Do you want me to do that while I'm in here?

No. How about you add some comments to #309 (which is an old issue about writing an exercise generator).

Thanks.

@verdammelt verdammelt merged commit b49abd6 into exercism:main Nov 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using roswell to run tests.
2 participants