Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the tests for Sphinx 8.1 #200

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mitya57
Copy link
Contributor

@mitya57 mitya57 commented Nov 24, 2024

Fixes #199.

@mitya57 mitya57 mentioned this pull request Nov 24, 2024
@foster999
Copy link
Collaborator

foster999 commented Nov 25, 2024

Which dependency has added the new class? As it's not functional for our package, it would be best to ignore this in our tests rather than add it to them - see the section above your change that does this for pygments

P.s. thanks for taking a look at this ☺️

@mitya57
Copy link
Contributor Author

mitya57 commented Nov 25, 2024

It is not a new dependency. It is caused by sphinx-doc/sphinx@eb6ff0a — on the contrary, the tests now use the built-in basic theme instead of alabaster which is a separate package.

Last time you told me that “it would be best for the tests to reflect the latest sphinx version”, so this is what I did here. If you prefer to remove this block like done for Pygments — let me know, I will redo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.4.7: pytest fails
2 participants