-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EAK-366] Implemented Autocomplete component #385
base: epic/new-components
Are you sure you want to change the base?
Conversation
CLA Assistant Lite bot: Thank you for your submission, we really appreciate it. We ask that you sign our Contributor Licence Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format. I have read the CLA Document and I hereby sign the CLA akaliada seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally very nice, thank you 👍 .
Please name either the pull-request and the commits according to the requirements:
[EAK-365] Bla-bla
https://github.com/exadel-inc/etoolbox-authoring-kit/blob/master/CONTRIBUTING.md#procedural-pull-request-questions
Please test/make sure that the new component works
a) in multifields
b) with DependsOn actions, such as "visible", "disabled", and especially "set" and "set-if-blank"
core/src/main/java/com/exadel/aem/toolkit/api/annotations/meta/ResourceTypes.java
Outdated
Show resolved
Hide resolved
...ain/java/com/exadel/aem/toolkit/api/annotations/widgets/autocompletecoral3/Autocomplete.java
Outdated
Show resolved
Hide resolved
...ain/java/com/exadel/aem/toolkit/api/annotations/widgets/autocompletecoral3/Autocomplete.java
Outdated
Show resolved
Hide resolved
...ain/java/com/exadel/aem/toolkit/api/annotations/widgets/autocompletecoral3/Autocomplete.java
Outdated
Show resolved
Hide resolved
...ain/java/com/exadel/aem/toolkit/api/annotations/widgets/autocompletecoral3/Autocomplete.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/exadel/aem/toolkit/core/authoring/models/Autocomplete.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/exadel/aem/toolkit/core/authoring/models/Autocomplete.java
Show resolved
Hide resolved
core/src/main/java/com/exadel/aem/toolkit/core/authoring/models/Option.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/exadel/aem/toolkit/core/authoring/models/Autocomplete.java
Outdated
Show resolved
Hide resolved
plugin/src/test/com/exadel/aem/toolkit/test/widget/AutocompleteWidget.java
Outdated
Show resolved
Hide resolved
Tested in multifields, with DependsOn actions, such as "visible", "disabled", and especially "set" and "set-if-blank" |
…to feature/EAK-366-autocomplete
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package com.exadel.aem.toolkit.api.annotations.widgets.autocomplete3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
package com.exadel.aem.toolkit.api.annotations.widgets.autocomplete3; | |
package com.exadel.aem.toolkit.api.annotations.widgets.?.autocomplete; |
No description provided.