update Req HttpClient example #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmineFrioua
approved these changes
Nov 21, 2023
woylie
force-pushed
the
fix-req-example
branch
from
6d80d12 to
b65b406
Compare
|
Thanks @woylie! Apologies for the delay in getting to this. |
reisub
added a commit
to reisub/ex_aws
that referenced
this pull request
Jan 3, 2024
This builds on work in ex-aws#1015 adding a bit of code to adjust the header format to the expected list of 2-element tuples. Req 0.4+ changed the header format to be a map where the key is a string and the value is a list of strings, e.g.: ```elixir %{ "content-length" => ["12345"] } ``` This change makes the current example fail whenever you try to perform a streaming operation because this code in `ExAws.S3.Download` assumes a single value: ```elixir defp get_file_size(bucket, path, config) do %{headers: headers} = ExAws.S3.head_object(bucket, path) |> ExAws.request!(config) headers |> Enum.find(fn {k, _} -> String.downcase(k) == "content-length" end) |> elem(1) |> String.to_integer() end ``` With the proposed change, the example implementation should handle both new and old Req versions; though I've only tested with a recent one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the Req example in the
ExAws.Request.HttpClientdocumentation.decode_body: falseto prevent Req from decoding JSON responses on its own (behaviour expects binary body).statustostatus_codein response to conform to behaviour. I know ex_aws was updated to map the response on its own in the main branch, but the behaviour still prescribes astatus_codefield.@impl.moduledocto example for easier copy-and-paste into projects that enforce module docs with linter rules.