Adds key creation for http signatures

Resolves issue openfaas#1103 Signed-off-by: Edward Wilde <[email protected]>
ewilde · Feb 24, 2019 · 9c7951a · 9c7951a
1 parent 44f423b
commit 9c7951a
Show file tree

Hide file tree

Showing 5 changed files with 306 additions and 59 deletions.
diff --git a/deploy_stack.sh b/deploy_stack.sh
@@ -1,66 +1,128 @@
-#!/bin/sh
-
-if ! [ -x "$(command -v docker)" ]; then
-  echo 'Unable to find docker command, please install Docker (https://www.docker.com/) and retry' >&2
-  exit 1
-fi
+#!/usr/bin/env bash
+set -e
 
+CHECK_MARK="\033[0;32m\xE2\x9C\x94\033[0m"
+PARTY_POPPER="\xF0\x9F\x8E\x89"
+DEBUG_LOG=${DEBUG_LOG:=0}
 export BASIC_AUTH="true"
 
-sha_cmd="shasum -a 256"
-if ! command -v shasum >/dev/null; then
-  sha_cmd="sha256sum"
-fi
+function debug() {
+    if [[ ${DEBUG_LOG} = "1" ]]; then
+        echo -e "$*";
+    fi
+}
+
+check_required_software() {
+    echo -en " Required software check"
+
+    if ! [[ -x "$(command -v docker)" ]]; then
+        echo 'Unable to find docker command, please install Docker (https://www.docker.com/) and retry' >&2
+        exit 1
+    fi
+
+    echo -e "\r${CHECK_MARK} Required software check"
+}
+
+setup_http_signature() {
+    echo -en " Http encryption settings"
+
+    rm signing.key > /dev/null 2>&1 || true && rm signing.key.pub > /dev/null 2>&1 || true
+    docker secret rm http-signing-private-key > /dev/null 2>&1 || true
+    docker secret rm http-signing-public-key > /dev/null 2>&1 || true
+
+    ssh-keygen -t rsa -b 2048 -N "" -m PEM -f signing.key > /dev/null 2>&1
+    openssl rsa -in ./signing.key -pubout -outform PEM -out signing.key.pub > /dev/null 2>&1
+
+    cat signing.key | docker secret create http-signing-private-key - > /dev/null 2>&1 || true
+    cat signing.key.pub | docker secret create http-signing-public-key - > /dev/null 2>&1 || true
+
+    rm signing.key || true && rm signing.key.pub || true
+    echo -e "\r${CHECK_MARK} Http encryption settings"
+}
+
+setup_basic_auth() {
+    sha_cmd="shasum -a 256"
+    if ! command -v shasum >/dev/null; then
+      sha_cmd="sha256sum"
+    fi
+
+    # Secrets should be created even if basic-auth is disabled.
+    if (echo "admin" | docker secret create basic-auth-user - > /dev/null 2>&1)
+    then
+      debug "[Credentials]\n\tusername: admin created"
+    fi
 
-while [ ! $# -eq 0 ]
+    secret=$(head -c 16 /dev/urandom| $sha_cmd | cut -d " " -f 1)
+    if (echo "$secret" | docker secret create basic-auth-password - > /dev/null 2>&1)
+    then
+      echo -e "[Credentials]\n\tusername: admin \n\tpassword: ${secret}\n\techo -n \"${secret}\" | faas-cli login --username=admin --password-stdin"
+    else
+      debug "[Credentials]\n\talready exist, not creating"
+    fi
+
+    if [[ ${BASIC_AUTH} = "true" ]];
+    then
+      debug "\tenabling basic authentication for gateway.."
+      debug ""
+    else
+      debug "\tdisabling basic authentication for gateway.."
+      debug ""
+    fi
+
+    echo -e "\r${CHECK_MARK} Basic authentication settings"
+}
+
+deploy_docker_stack() {
+    arch=$(uname -m)
+    case "$arch" in
+
+    "armv7l") echo -en " Deploying OpenFaaS core services for ARM"
+              composefile="docker-compose.armhf.yml"
+              ;;
+    "aarch64") echo -en " Deploying OpenFaaS core services for ARM64"
+              composefile="docker-compose.arm64.yml"
+              ;;
+    *) echo -en " Deploying OpenFaaS core services"
+       composefile="docker-compose.yml"
+       ;;
+    esac
+
+    docker stack deploy func --compose-file ${composefile} > /dev/null
+    echo -e "\r${CHECK_MARK} Deploying OpenFaaS core services"
+}
+
+main() {
+    check_required_software
+    setup_basic_auth
+    setup_http_signature
+    deploy_docker_stack
+    echo -e ${PARTY_POPPER}OpenFaaS docker swarm setup complete
+}
+
+POSITIONAL=()
+while [[ $# -gt 0 ]]
 do
-	case "$1" in
-		--no-auth | -n)
-			export BASIC_AUTH="false"
-			;;
-    --help | -h)
-			echo "Usage: \n [default]\tdeploy the OpenFaaS core services\n --no-auth [-n]\tdisable basic authentication.\n --help\tdisplays this screen"
-      exit
-			;;
-	esac
-	shift
-done
+key="$1"
 
-# Secrets should be created even if basic-auth is disabled.
-echo "Attempting to create credentials for gateway.."
-echo "admin" | docker secret create basic-auth-user -
-secret=$(head -c 16 /dev/urandom| $sha_cmd | cut -d " " -f 1)
-echo "$secret" | docker secret create basic-auth-password -
-if [ $? = 0 ];
-then
-  echo "[Credentials]\n username: admin \n password: $secret\n echo -n "$secret" | faas-cli login --username=admin --password-stdin"
-else
-  echo "[Credentials]\n already exist, not creating"
-fi
-
-if [ $BASIC_AUTH = "true" ];
-then
-  echo ""
-  echo "Enabling basic authentication for gateway.."
-  echo ""
-else
-  echo ""
-  echo "Disabling basic authentication for gateway.."
-  echo ""
-fi
-
-arch=$(uname -m)
-case "$arch" in
-
-"armv7l") echo "Deploying OpenFaaS core services for ARM"
-          composefile="docker-compose.armhf.yml"
-          ;;
-"aarch64") echo "Deploying OpenFaaS core services for ARM64"
-          composefile="docker-compose.arm64.yml"
-          ;;
-*) echo "Deploying OpenFaaS core services"
-   composefile="docker-compose.yml"
-   ;;
+case $key in
+    --no-auth | -n)
+        export BASIC_AUTH="false"
+        shift
+        ;;
+    --debug | -d)
+        DEBUG_LOG="1"
+        shift
+        ;;
+    --help | -h)
+        echo -e "Usage:
+[default]      deploy the OpenFaaS core services
+--no-auth [-n] disable basic authentication.
+--help         displays this screen
+--debug [-d]   enable debug logging"
+        exit
+        ;;
 esac
+done
+set -- "${POSITIONAL[@]}" # restore positional parameters
 
-docker stack deploy func --compose-file $composefile
+main
diff --git a/docker-compose.yml b/docker-compose.yml
@@ -38,6 +38,7 @@ services:
         secrets:
             - basic-auth-user
             - basic-auth-password
+            - http-signing-public-key
 
     # Docker Swarm provider
     faas-swarm:
@@ -117,6 +118,7 @@ services:
         secrets:
             - basic-auth-user
             - basic-auth-password
+            - http-signing-private-key
 
     # End services
 
@@ -198,3 +200,7 @@ secrets:
         external: true
     basic-auth-password:
         external: true
+    http-signing-public-key:
+        external: true
+    http-signing-private-key:
+        external: true
diff --git a/gateway/handlers/certificates_handler.go b/gateway/handlers/certificates_handler.go
@@ -0,0 +1,81 @@
+package handlers
+
+import (
+	"encoding/json"
+	"fmt"
+	"io/ioutil"
+	"log"
+	"net/http"
+	"os"
+
+	"github.com/gorilla/mux"
+)
+
+var keyMap = map[string]string{
+	"callback": "http-signing-public-key",
+}
+
+type KeyType struct {
+	Id  string `json:"id"`
+	PEM string `json:"pem"`
+}
+
+type SecretsReader interface {
+	Read(key string) (string, error)
+}
+
+type FileSecretsReader struct{}
+
+func (f *FileSecretsReader) Read(key string) (string, error) {
+	if _, err := os.Stat(fmt.Sprintf("/run/secrets/%s", key)); os.IsNotExist(err) {
+		return "", fmt.Errorf("unable to find secret %s", key)
+	}
+
+	value, err := ioutil.ReadFile(fmt.Sprintf("/run/secrets/%s", key))
+	if err != nil {
+		return "", fmt.Errorf("error reading find secret %s", key)
+	}
+
+	return string(value), nil
+}
+
+func MakeCertificatesHandler(reader SecretsReader) http.HandlerFunc {
+	return func(w http.ResponseWriter, r *http.Request) {
+		vars := mux.Vars(r)
+		keyID := vars["id"]
+		secretKey, ok := keyMap[keyID]
+		if !ok {
+			w.WriteHeader(http.StatusNotFound)
+			message := fmt.Sprintf("Unable to find certificate %s.", keyID)
+			w.Write([]byte(message))
+			log.Println(message)
+			return
+		}
+
+		publicKey, err := reader.Read(secretKey)
+		if err != nil {
+			w.WriteHeader(http.StatusNotFound)
+			message := fmt.Sprintf("Unable to find secret for key %s.", keyID)
+			w.Write([]byte(message))
+			log.Println(message)
+			return
+		}
+
+		key := &KeyType{
+			Id:  secretKey,
+			PEM: publicKey,
+		}
+
+		bytesOut, marshalErr := json.Marshal(key)
+		if marshalErr != nil {
+			w.WriteHeader(http.StatusInternalServerError)
+			message := fmt.Sprintf("error marshalling json for key %s. %v", keyID, err)
+			w.Write([]byte(message))
+			log.Println(message)
+		}
+
+		w.Header().Set("Content-Type", "application/json")
+		w.WriteHeader(http.StatusOK)
+		w.Write(bytesOut)
+	}
+}
diff --git a/gateway/handlers/certificates_handler_test.go b/gateway/handlers/certificates_handler_test.go
@@ -0,0 +1,98 @@
+package handlers
+
+import (
+	"encoding/json"
+	"fmt"
+	"io/ioutil"
+	"net/http"
+	"net/http/httptest"
+	"testing"
+
+	"github.com/gorilla/mux"
+)
+
+func TestMakeCertificatesHandler(t *testing.T) {
+	tests := []struct {
+		name   string
+		keyID  string
+		eval   func(r *http.Response) error
+		reader SecretsReader
+	}{
+		{
+			name:  "Get certificate",
+			keyID: "callback",
+			eval: func(r *http.Response) error {
+				if r.StatusCode != 200 {
+					return fmt.Errorf("expected 200")
+				}
+
+				body, _ := ioutil.ReadAll(r.Body)
+				keyData := &KeyType{}
+				if err := json.Unmarshal(body, keyData); err != nil {
+					return fmt.Errorf("error unmarshalling result")
+				}
+
+				if keyData.PEM != testPublicKey {
+					return fmt.Errorf("PEM want %s got %s", testPublicKey, keyData.PEM)
+				}
+				return nil
+			},
+			reader: &TestSecretsReader{readCallBack: func(key string) (s string, e error) {
+				return testPublicKey, nil
+			}},
+		},
+		{
+
+			name:  "Unable to find certificate",
+			keyID: "missingID",
+			eval: func(r *http.Response) error {
+				if r.StatusCode != 404 {
+					return fmt.Errorf("expected 404")
+				}
+
+				return nil
+			},
+			reader: &TestSecretsReader{readCallBack: func(key string) (s string, e error) {
+				return "", fmt.Errorf("key not found")
+			}},
+		},
+	}
+
+	r := mux.NewRouter()
+	ts := httptest.NewServer(r)
+	defer ts.Close()
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			r.HandleFunc("/certificates/{id}", MakeCertificatesHandler(tt.reader))
+
+			url := ts.URL + "/certificates/" + tt.keyID
+			resp, err := http.Get(url)
+			if err != nil {
+				t.Errorf("MakeCertificatesHandler() call = %v", err)
+			}
+
+			if err := tt.eval(resp); err != nil {
+				t.Errorf("MakeCertificatesHandler() eval = %v", err)
+			}
+		})
+	}
+}
+
+type TestSecretsReader struct {
+	readCallBack func(key string) (string, error)
+}
+
+func (r *TestSecretsReader) Read(key string) (string, error) {
+	return r.readCallBack(key)
+}
+
+const testPublicKey = `-----BEGIN PUBLIC KEY-----
+MIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA7pEUKQ28pI5N3g/zG6OJ
+100N/DV2Q8Ob+gzRjd7HjXgVgZyjS3nA8FAYrxTLSihcIhXuQrYxyk2vp6YMNmSB
+fOptkdmj4UgLYskfeqEt8JjS6ExBxSWEDgr1IXOPPDP61on8F65/ZYGnp2JF2wHY
+k0OeD4ppNUV+mIHj/wXf7VLHGflwFQH/+mfUn+tVQRgX7hTadcYmGJ+1XP0py4kU
+gJDHfw8eBsFurHWr2mXu3BdraSKKf1G9i+SifmOUUul6mBONmlvzQdKtDCr48o1H
+QndRHcMWjKhlBhKz4qrmqku8oGBh6iHhGVVYf8D3mU1nzyjH4rOUXZwzj+SaqgGk
+vQIDAQAB
+-----END PUBLIC KEY-----`