Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor performance improvements #110

Merged
merged 4 commits into from
Jan 25, 2024
Merged

Minor performance improvements #110

merged 4 commits into from
Jan 25, 2024

Commits on Jan 22, 2024

  1. Pass owned paths to id_from_canonical 

    id_from_canonical ideally takes owned strings
instead of references to avoid a copy.
    @Colecf
    Colecf committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    76eddcb View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Precalcuate length of evaluated strings 

    So that we can do one memory allocation for them.
    @Colecf
    Colecf committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    83a15dc View commit details
    Browse the repository at this point in the history

  2. Only hash strings once in id_from_canonical 

    Use HashMap.entry() instead of a lookup + insert.
    @Colecf
    Colecf committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    9ea052e View commit details
    Browse the repository at this point in the history

  3. Switch some HashMaps to FxHashMaps 

    FxHashMap has a faster hashing algorithm,
at the expense of not being resistent to DOS
attacks.
    @Colecf
    Colecf committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    a24eb9c View commit details
    Browse the repository at this point in the history