Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add protobuf generated files #616

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

denysvitali
Copy link

If you want to use the UI module in another project, Go will not
allow you to import the package because the ui protobuf package
is missing. We have to commit it so that we can allow this
project to be used as a library.

If you want to use the UI module in another project, Go will not
allow you to import the package because the ui protobuf package
is missing. We have to commit it so that we can allow this
project to be used as a library.
@gustavo-iniguez-goya
Copy link
Collaborator

hey @denysvitali , they were added to the repo some time ago, but I don't remember why we deleted it. @themighty1 can you help here? any opinion against adding protobuffers to the repo?

Anyhow, if they need to be added, I'll add the ones that have been distributed with latest release.

Just out of curiosity O:) , may I ask you how are you using this repo as lib/package?

@denysvitali
Copy link
Author

Just out of curiosity O:) , may I ask you how are you using this repo as lib/package?

I actually wanted to create a small web UI (I don't like the Python UI), but I later realized that the "UI Client" is in fact a client for the daemon, which in turn seems to be an hub for multiple "UI Clients" (computers?).

What I wanted to have is an UI for a single node. Do you have maybe an architecture overview of the project?

@gustavo-iniguez-goya
Copy link
Collaborator

Nope. Some time ago I started a tui client, where I separated the daemon from the TUI logic with your idea in mind: allow to have multiple clients that connect to the server (GUI/TUI/web..). I commented out the code, and bear in mind that I wrote it in a few days and never reviewed it again .. O:)

https://github.com/gustavo-iniguez-goya/opensnitch/tree/cli/server/api
https://github.com/gustavo-iniguez-goya/opensnitch/tree/cli/server/cli

@ple1n
Copy link

ple1n commented Jan 5, 2024

why. they are generated. add them to .gitignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants