Add custom csv delimiter option #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, you'll have to forgive me for this is my very first Python PR. I may be completely unawares of how you can pull this off in another way. If anything whatsoever needs changing, know you're talking to a Python n00b, but a professional programmer.
Anyway, I was finding myself in need of this functionality as I had fields with
,in them, pesky formatted currencies for example.I'm by no means a 🐍 Wizard and I enjoyed stumbling upon this project to learn how to do basic things. Including Unit Tests and a bunch of other concepts I would use in Swift/Obj-C/JavaScript. The project is well laid out and with reasonably sized clean functions, and tests!
I did consider refactoring how the CSV writing occurred, so that the Unit Tests didn't have to rely on an outputted file, nor having to cleanup afterwards. But wanted to see if this would pass.