Skip to content
This repository has been archived by the owner on Aug 3, 2021. It is now read-only.

Commit

Permalink
Clean up contacts controller spec (chapter 7)
Browse files Browse the repository at this point in the history
  • Loading branch information
@ruralocity
ruralocity committed Sep 25, 2014
1 parent e4fe9bc commit 129cf33
Show file tree
Hide file tree
Showing 4 changed files with 77 additions and 204 deletions.
256 changes: 52 additions & 204 deletions spec/controllers/contacts_controller_spec.rb
View file
Original file line number Diff line number Diff line change
@@ -1,12 +1,7 @@
require 'rails_helper'

describe ContactsController do
describe "administrator access" do
before :each do
user = create(:admin)
session[:user_id] = user.id
end

shared_examples_for 'public access to contacts' do
describe 'GET #index' do
context 'with params[:letter]' do
it "populates an array of contacts starting with the letter" do
Expand Down Expand Up @@ -50,13 +45,23 @@
expect(response).to render_template :show
end
end
end

shared_examples 'full access to contacts' do
describe 'GET #new' do
it "assigns a new Contact to @contact" do
get :new
expect(assigns(:contact)).to be_a_new(Contact)
end

it "assigns a home, office, and mobile phone to the new contact" do
get :new
phones = assigns(:contact).phones.map do |p|
p.phone_type
end
expect(phones).to match_array %w(home office mobile)
end

it "renders the :new template" do
get :new
expect(response).to render_template :new
Expand Down Expand Up @@ -95,17 +100,18 @@
end

it "redirects to contacts#show" do
post :create, contact: attributes_for(:contact,
phones_attributes: @phones)
post :create,
contact: attributes_for(:contact,
phones_attributes: @phones)
expect(response).to redirect_to contact_path(assigns[:contact])
end
end

context "with invalid attributes" do
it "does not save the new contact in the database" do
expect{
post :create,
contact: attributes_for(:invalid_contact)
post :create, contact:
attributes_for(:invalid_contact)
}.to_not change(Contact, :count)
end

Expand All @@ -121,23 +127,25 @@
before :each do
@contact = create(:contact,
firstname: 'Lawrence',
lastname: 'Smith')
lastname: 'Smith'
)
end

context "valid attributes" do
it "locates the requested @contact" do
patch :update, id: @contact, contact: attributes_for(:contact)
expect(assigns(:contact)).to eq(@contact)
expect(assigns(:contact)).to eq @contact
end

it "changes @contact's attributes" do
it "changes the contact's attributes" do
patch :update, id: @contact,
contact: attributes_for(:contact,
firstname: 'Larry',
lastname: 'Smith')
lastname: 'Smith'
)
@contact.reload
expect(@contact.firstname).to eq('Larry')
expect(@contact.lastname).to eq('Smith')
expect(@contact.firstname).to eq 'Larry'
expect(@contact.lastname).to eq 'Smith'
end

it "redirects to the updated contact" do
Expand All @@ -146,20 +154,25 @@
end
end

context "with invalid attributes" do
context "invalid attributes" do
it "locates the requested @contact" do
patch :update, id: @contact, contact: attributes_for(:invalid_contact)
expect(assigns(:contact)).to eq @contact
end

it "does not change the contact's attributes" do
patch :update, id: @contact,
contact: attributes_for(:contact,
firstname: 'Larry',
lastname: nil)
lastname: nil
)
@contact.reload
expect(@contact.firstname).to_not eq('Larry')
expect(@contact.lastname).to eq('Smith')
expect(@contact.firstname).to_not eq 'Larry'
expect(@contact.lastname).to eq 'Smith'
end

it "re-renders the edit template" do
patch :update, id: @contact,
contact: attributes_for(:invalid_contact)
it "re-renders the edit method" do
patch :update, id: @contact, contact: attributes_for(:invalid_contact)
expect(response).to render_template :edit
end
end
Expand All @@ -183,227 +196,62 @@
end
end

describe "user access" do
describe "administrator access" do
before :each do
user = create(:user)
session[:user_id] = user.id
end

describe 'GET #index' do
context 'with params[:letter]' do
it "populates an array of contacts starting with the letter" do
smith = create(:contact, lastname: 'Smith')
jones = create(:contact, lastname: 'Jones')
get :index, letter: 'S'
expect(assigns(:contacts)).to match_array([smith])
end

it "renders the :index template" do
get :index, letter: 'S'
expect(response).to render_template :index
end
end

context 'without params[:letter]' do
it "populates an array of all contacts" do
smith = create(:contact, lastname: 'Smith')
jones = create(:contact, lastname: 'Jones')
get :index
expect(assigns(:contacts)).to match_array([smith, jones])
end

it "renders the :index template" do
get :index
expect(response).to render_template :index
end
end
end

describe 'GET #show' do
it "assigns the requested contact to @contact" do
contact = create(:contact)
get :show, id: contact
expect(assigns(:contact)).to eq contact
end

it "renders the :show template" do
contact = create(:contact)
get :show, id: contact
expect(response).to render_template :show
end
end

describe 'GET #new' do
it "assigns a new Contact to @contact" do
get :new
expect(assigns(:contact)).to be_a_new(Contact)
end

it "renders the :new template" do
get :new
expect(response).to render_template :new
end
end

describe 'GET #edit' do
it "assigns the requested contact to @contact" do
contact = create(:contact)
get :edit, id: contact
expect(assigns(:contact)).to eq contact
end

it "renders the :edit template" do
contact = create(:contact)
get :edit, id: contact
expect(response).to render_template :edit
end
set_user_session create(:admin)
end

describe "POST #create" do
before :each do
@phones = [
attributes_for(:phone),
attributes_for(:phone),
attributes_for(:phone)
]
end

context "with valid attributes" do
it "saves the new contact in the database" do
expect{
post :create, contact: attributes_for(:contact,
phones_attributes: @phones)
}.to change(Contact, :count).by(1)
end

it "redirects to contacts#show" do
post :create, contact: attributes_for(:contact,
phones_attributes: @phones)
expect(response).to redirect_to contact_path(assigns[:contact])
end
end

context "with invalid attributes" do
it "does not save the new contact in the database" do
expect{
post :create,
contact: attributes_for(:invalid_contact)
}.to_not change(Contact, :count)
end

it "re-renders the :new template" do
post :create,
contact: attributes_for(:invalid_contact)
expect(response).to render_template :new
end
end
end

describe 'PATCH #update' do
before :each do
@contact = create(:contact,
firstname: 'Lawrence',
lastname: 'Smith')
end

context "valid attributes" do
it "locates the requested @contact" do
patch :update, id: @contact, contact: attributes_for(:contact)
expect(assigns(:contact)).to eq(@contact)
end

it "changes @contact's attributes" do
patch :update, id: @contact,
contact: attributes_for(:contact,
firstname: 'Larry',
lastname: 'Smith')
@contact.reload
expect(@contact.firstname).to eq('Larry')
expect(@contact.lastname).to eq('Smith')
end

it "redirects to the updated contact" do
patch :update, id: @contact, contact: attributes_for(:contact)
expect(response).to redirect_to @contact
end
end

context "with invalid attributes" do
it "does not change the contact's attributes" do
patch :update, id: @contact,
contact: attributes_for(:contact,
firstname: 'Larry',
lastname: nil)
@contact.reload
expect(@contact.firstname).to_not eq('Larry')
expect(@contact.lastname).to eq('Smith')
end
it_behaves_like 'public access to contacts'
it_behaves_like 'full access to contacts'
end

it "re-renders the edit template" do
patch :update, id: @contact,
contact: attributes_for(:invalid_contact)
expect(response).to render_template :edit
end
end
describe "user access" do
before :each do
set_user_session create(:user)
end

describe 'DELETE #destroy' do
before :each do
@contact = create(:contact)
end

it "deletes the contact" do
expect{
delete :destroy, id: @contact
}.to change(Contact,:count).by(-1)
end

it "redirects to contacts#index" do
delete :destroy, id: @contact
expect(response).to redirect_to contacts_url
end
end
it_behaves_like 'public access to contacts'
it_behaves_like 'full access to contacts'
end

describe "guest access" do
# GET #index and GET #show examples are the same as those for
# administrators and users
it_behaves_like 'public access to contacts'

describe 'GET #new' do
it "requires login" do
get :new
expect(response).to redirect_to login_url
expect(response).to require_login
end
end

describe 'GET #edit' do
it "requires login" do
contact = create(:contact)
get :edit, id: contact
expect(response).to redirect_to login_url
expect(response).to require_login
end
end

describe "POST #create" do
it "requires login" do
post :create, id: create(:contact),
contact: attributes_for(:contact)
expect(response).to redirect_to login_url
expect(response).to require_login
end
end

describe 'PUT #update' do
it "requires login" do
put :update, id: create(:contact),
contact: attributes_for(:contact)
expect(response).to redirect_to login_url
expect(response).to require_login
end
end

describe 'DELETE #destroy' do
it "requires login" do
delete :destroy, id: create(:contact)
expect(response).to redirect_to login_url
expect(response).to require_login
end
end
end
Expand Down
3 changes: 3 additions & 0 deletions spec/rails_helper.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@
# Include Factory Girl syntax to simplify calls to factories
config.include FactoryGirl::Syntax::Methods

# Include custom login macros
config.include LoginMacros

# If you're not using ActiveRecord, or you'd prefer not to run each of your
# examples within a transaction, remove the following line or assign false
# instead of true.
Expand Down
5 changes: 5 additions & 0 deletions spec/support/login_macros.rb
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
module LoginMacros
def set_user_session(user)
session[:user_id] = user.id
end
end
Loading

0 comments on commit 129cf33

Please sign in to comment.