Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix critical errors #83

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions sdk/Eversign/ApiRequest.php
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ class ApiRequest {
* @param string $accessKey
* @param string $endPoint
* @param string $serializeClass
* @param [] $parameters
* @param [] $payLoad
* @param array $parameters
* @param array $payLoad
*/

public function __construct(
Expand Down Expand Up @@ -94,7 +94,6 @@ public function __construct(
$this->serializeClass = $serializeClass;
$this->parameters = $parameters;
$this->payLoad = $payLoad;
$this->apiB = $apiBaseUrl;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 Removed stray property.


$this->guzzleRequestTimeout = $apiRequestTimeout;
}
Expand Down Expand Up @@ -150,7 +149,7 @@ private function createQuery() {

/**
* Starts a MultiPart Upload Request to the API
* @return []
* @return object
* @throws \Exception
*/
public function startMultipartUpload() {
Expand Down Expand Up @@ -187,7 +186,7 @@ public function startMultipartUpload() {
* Starts the configured API Request of the ApiRequest instance.
* Returns different objects based on the request sent. Consult the Eversign API
* documentation for more information.
* @return stdClass
* @return \stdClass
* @throws \Exception
*/
public function startRequest() {
Expand Down
2 changes: 1 addition & 1 deletion sdk/Eversign/Business.php
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ public function setIsPrimary($isPrimary) {

/**
* Returns the Creation Date of the Business
* @return DateTime
* @return \DateTime
*/
public function getCreationTimeStamp() {
return $this->creationTimeStamp;
Expand Down
34 changes: 17 additions & 17 deletions sdk/Eversign/Client.php
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class Client {
/**
* Reference to the Access Key
*
* @var Access Key $accessKey
* @var string $accessKey
*/
protected $accessKey;

Expand All @@ -59,7 +59,7 @@ class Client {

/**
* The selected Business which will be used for subsequent API requests
* @var \Business $selectedBusiness
* @var \Eversign\Business $selectedBusiness
*/
private $selectedBusiness;

Expand Down Expand Up @@ -121,7 +121,7 @@ public function getBusinesses() {
/**
* Requests a OAuth Access Token
*
* @return $oauthAccessToken
* @return string
*/
public function generateOAuthAuthorizationUrl($obj) {
if(!array_key_exists('client_id', $obj)) {
Expand All @@ -138,7 +138,7 @@ public function generateOAuthAuthorizationUrl($obj) {
/**
* Requests a OAuth Access Token
*
* @return $oauthAccessToken
* @return string
*/
public function requestOAuthToken(OAuthTokenRequest $token_request) {
$request = new ApiRequest(
Expand All @@ -158,7 +158,7 @@ public function requestOAuthToken(OAuthTokenRequest $token_request) {
/**
* Sets a OAuth Access Token to beeing used as the access_key
*
* @return $oauthAccessToken
* @return void
*/
public function setOAuthAccessToken($oauthToken) {
$this->accessKey = 'Bearer ' . $oauthToken;
Expand All @@ -168,7 +168,7 @@ public function setOAuthAccessToken($oauthToken) {
/**
* Retrieves all available Business for the current Client
*
* @return \Business[]
* @return void
*/
public function fetchBusinesses($setDefault = true) {
if($this->accessKey) {
Expand Down Expand Up @@ -260,31 +260,31 @@ private function getDocuments($type = "all") {
/**
* Returns all Documents for the Client without filtering the state
* Only exception are deleted Documents
* @return \Document[]
* @return \Eversign\Document[]
*/
public function getAllDocuments() {
return $this->getDocuments();
}

/**
* Returns all Completed Documents for the Client
* @return \Document[]
* @return \Eversign\Document[]
*/
public function getCompletedDocuments() {
return $this->getDocuments("completed");
}

/**
* Returns all Documents which are still in Draft
* @return \Document[]
* @return \Eversign\Document[]
*/
public function getDraftDocuments() {
return $this->getDocuments("drafts");
}

/**
* Returns all canceled Documents for the Client
* @return \Document[]
* @return \Eversign\Document[]
*/
public function getCanceledDocuments() {
return $this->getDocuments("cancelled");
Expand All @@ -293,7 +293,7 @@ public function getCanceledDocuments() {
/**
* Returns all Documents for the Client which require Actions
* from the User
* @return \Document[]
* @return \Eversign\Document[]
*/
public function getActionRequiredDocuments() {
return $this->getDocuments("my_action_required");
Expand All @@ -302,15 +302,15 @@ public function getActionRequiredDocuments() {
/**
* Returns all Documents for the Client which are waiting on responses
* from others.
* @return \Document[]
* @return \Eversign\Document[]
*/
public function getWaitingForOthersDocuments() {
return $this->getDocuments("waiting_for_others");
}

/**
* Returns a list of Documents which are set to be Templates
* @return \Document[]
* @return \Eversign\Document[]
*/
public function getTemplates() {
return $this->getDocuments("templates");
Expand All @@ -319,7 +319,7 @@ public function getTemplates() {
/**
* Returns a list of Documents which are set to be Templates
* which are also set to be archived
* @return \Document[]
* @return \Eversign\Document[]
*/
public function getArchivedTemplates() {
return $this->getDocuments("templates_archived");
Expand All @@ -328,7 +328,7 @@ public function getArchivedTemplates() {
/**
* Returns a list of Documents which are set to be Templates
* which are also set to be drafts
* @return \Document[]
* @return \Eversign\Document[]
*/
public function getDraftTemplates() {
return $this->getDocuments("template_drafts");
Expand All @@ -340,7 +340,7 @@ public function getDraftTemplates() {
* Returns true or false whether the reminder has been sent
* @param \Eversign\Document $document
* @param \Eversign\Signer $signer
* @throws Exception
* @throws \Exception
* @return boolean success
*/
public function sendReminderForDocument(Document $document, Signer $signer) {
Expand Down Expand Up @@ -642,7 +642,7 @@ public function deleteDocument(Document $document, $type=NULL) {
/**
* Cancels the specified Document. After canceling the Document
* it can be deleted.
* @param type $document
* @param \Eversign\Document $document
* @return boolean success
*/
public function cancelDocument($document) {
Expand Down
10 changes: 5 additions & 5 deletions sdk/Eversign/Document.php
Original file line number Diff line number Diff line change
Expand Up @@ -224,39 +224,39 @@ class Document {
/**
* Array of Signer Objects which are associated with the Document
*
* @var array<Eversign\Signer> $signers
* @var array<\Eversign\Signer> $signers
* @Type("array<Eversign\Signer>")
*/
private $signers;

/**
* Array of Recipient Objects which are associated with the Document
*
* @var array<Eversign\Recipient> $signers
* @var array<\Eversign\Recipient> $signers
* @Type("array<Eversign\Recipient>")
*/
private $recipients;

/**
* Array of LogEntry Objects which are associated with the Document
*
* @var array<Eversign\LogEntry> $log
* @var array<\Eversign\LogEntry> $log
* @Type("array<Eversign\LogEntry>")
*/
private $log;

/**
* Array of FormField Objects and there respective Subclass
*
* @var array<array<Eversign\FormField>> $fields
* @var array<array<\Eversign\FormField>> $fields
* @Type("array<array<Eversign\FormField>>")
*/
private $fields;

/**
* Array of File Objects which are associated with the Document
*
* @var array<Eversign\File> $files
* @var array<\Eversign\File> $files
* @Type("array<Eversign\File>")
*/
private $files;
Expand Down
6 changes: 3 additions & 3 deletions sdk/Eversign/DocumentTemplate.php
Original file line number Diff line number Diff line change
Expand Up @@ -103,23 +103,23 @@ class DocumentTemplate {
/**
* Array of Signer Objects which are associated with the Document
*
* @var array<Eversign\Signer> $signers
* @var array<\Eversign\Signer> $signers
* @Type("array<Eversign\Signer>")
*/
private $signers;

/**
* Array of Recipient Objects which are associated with the Document
*
* @var array<Eversign\Recipient> $signers
* @var array<\Eversign\Recipient> $signers
* @Type("array<Eversign\Recipient>")
*/
private $recipients;

/**
* This object must contain a sub array for each Merge Field of this template.
*
* @var array<Eversign\Field> $fields
* @var array<\Eversign\Field> $fields
* @Type("array<Eversign\Field>")
*/
private $fields;
Expand Down
1 change: 0 additions & 1 deletion sdk/Eversign/InitialsField.php
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ class InitialsField extends FormField{

public function __construct() {
parent::__construct();
$this->type = "initials";
Copy link
Author

@szepeviktor szepeviktor Aug 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 Removed initialization of unknown property.

$this->setWidth(43);
$this->setHeight(43);
$this->setRequired(false);
Expand Down