DEVPROD-11922: Prevent task page from erroring due to missing distro (#…

…8503)

graphql/tests/task/imageId/data.json

@@ -14,6 +14,11 @@
       "_id": "container-task",
       "branch": "spruce",
       "container": "ubuntu1604-container"
+    },
+    {
+      "_id": "nonexistent-distro-task",
+      "branch": "spruce",
+      "distro": "i-was-deleted"
     }
   ],
   "distro": [

graphql/tests/task/imageId/queries/nonexistent_distro_task.graphql

@@ -0,0 +1,5 @@
+{
+  task(taskId: "nonexistent-distro-task") {
+    imageId
+  }
+}

graphql/tests/task/imageId/results.json

@@ -29,6 +29,16 @@
           }
         }
       }
+    },
+    {
+      "query_file": "nonexistent_distro_task.graphql",
+      "result": {
+        "data": {
+          "task": {
+            "imageId": ""
+          }
+        }
+      }
     }
   ]
 }

model/distro/distro.go

@@ -927,8 +927,9 @@ func GetImageIDFromDistro(ctx context.Context, distro string) (string, error) {
 	if err != nil {
 		return "", errors.Wrapf(err, "finding distro '%s'", distro)
 	}
+	// Do not return an error, as the distro may have been deleted.
 	if d == nil {
-		return "", errors.Errorf("distro '%s' not found", distro)
+		return "", nil
 	}
 	return d.ImageID, nil
 }