Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT-8535 add session duration to the sdk cookie #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pcharest
Copy link
Member

@pcharest pcharest commented Dec 11, 2024

Related issue(s)

> Link to jira ticket

https://github.com/everflow-io/go/pull/847
https://github.com/everflow-io/everflow-sdk-private/pull/5

Description

add session duration to the click cookie expiration

Development

  • Test plan created on Jira
  • Code is clean (linter, etc.)

Deployment

  • Are there deployment steps (new keys in CM, new pubsub topics, BQ columns, etc.) ? Are they documented in the infra migration ticket ?

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

@pcharest pcharest marked this pull request as ready for review December 11, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant