Refactor Admin to Work with New UI #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will fix linting, later, have to go make dinner |
hoseinrafiei
approved these changes
Apr 13, 2022
| */ | ||
| public static function add_promotions_form_inputs($before_payment_options) | ||
| { | ||
| public static function add_promotions_form_inputs(EE_Form_Section_Proper $before_payment_options |
There was a problem hiding this comment.
Suggested change
| public static function add_promotions_form_inputs(EE_Form_Section_Proper $before_payment_options | |
| public static function add_promotions_form_inputs(EE_Form_Section_Proper $before_payment_options): EE_Form_Section_Proper |
knazart
approved these changes
Apr 13, 2022
| let i = 0; | ||
| let num = 0; | ||
| let out = ''; | ||
| let ts=String(new Date().getTime()); |
There was a problem hiding this comment.
Suggested change
| let ts=String(new Date().getTime()); | |
| let ts = String(new Date().getTime()); |
Comment on lines
-72
to
+80
| uniqid: function() { | ||
| var ts=String(new Date().getTime()), i = 0, out = '',num=0; | ||
| var host = window.location.host; | ||
| uniqID: function() { | ||
| const host = window.location.host; | ||
| let i = 0; | ||
| let num = 0; | ||
| let out = ''; |
| @@ -151,7 +160,7 @@ jQuery(document).ready(function($){ | |||
| * @return {eePromotionsHelper} | |||
| */ | |||
| getScopeSelectionItems: function(page) { | |||
| var data={}; | |||
| const data={}; | |||
There was a problem hiding this comment.
Suggested change
| const data={}; | |
| const data = {}; |
| var doingstart = data.context == 'start' ? true : false; | ||
| dttPickerHelper.resetpicker().setDefaultDateRange('months', 1).picker(start, end, next, doingstart); | ||
| const data= $(this).data(); | ||
| // const container = data.container === 'main' ? '#promotion-details-mbox' : '#promotions-applied-to-mbox'; |
| $postBody.on( 'click', '.ee-toggle-datepicker', function(e) { | ||
| e.preventDefault(); | ||
| e.stopPropagation(); | ||
| const data = $(this).data(); |
There was a problem hiding this comment.
Suggested change
| const data = $(this).data(); | |
| const data = $(this).data(); |
| throw new EE_Error(sprintf(__('Something might be wrong with the models or the given Promotion ID in the request (%s) is not for a valid Promotion in the DB.', 'event_espresso'), $this->_req_data['PRO_ID'])); | ||
| throw new EE_Error( | ||
| sprintf( | ||
| __( |
There was a problem hiding this comment.
Suggested change
| __( | |
| esc_html__( |
| add_meta_box('promotions-applied-to-mbox', __('Promotion applies to...', 'event_espresso'), array( $this, 'promotions_applied_to_metabox'), $this->_wp_page_slug, 'side', 'default'); | ||
| add_meta_box( | ||
| 'promotion-details-mbox', | ||
| __('Promotions', 'event_espresso'), |
There was a problem hiding this comment.
Suggested change
| __('Promotions', 'event_espresso'), | |
| esc_html__('Promotions', 'event_espresso'), |
| ); | ||
| add_meta_box( | ||
| 'promotions-applied-to-mbox', | ||
| __('Promotion applies to...', 'event_espresso'), |
There was a problem hiding this comment.
Suggested change
| __('Promotion applies to...', 'event_espresso'), | |
| esc_html__('Promotion applies to...', 'event_espresso'), |
| */ | ||
| public function promotions_applied_to_metabox() | ||
| { | ||
| // we use the scope to get the metabox content. | ||
| $scope = $this->_promotion->scope_obj(); | ||
|
|
||
| // if there is no scope then this is a default promotion object so the content will for promotions metabox will be generic. | ||
| $content = empty($scope) ? __('When you select a scope for the promotion this area will have options related to the selection.', 'event_espresso') : $scope->get_admin_applies_to_selector($this->_promotion->ID()); | ||
| $content = empty($scope) ? __( |
There was a problem hiding this comment.
Suggested change
| $content = empty($scope) ? __( | |
| $content = empty($scope) ? esc_html__( |
A lot of these in this file. If even interested in fixing those here.
Comment on lines
+1283
to
+1286
| } elseif ( | ||
| property_exists($this->_config, $property) | ||
| && $this->_config->{$property} | ||
| !== $value |
There was a problem hiding this comment.
Suggested change
| } elseif ( | |
| property_exists($this->_config, $property) | |
| && $this->_config->{$property} | |
| !== $value | |
| } elseif ( | |
| property_exists($this->_config, $property) | |
| && $this->_config->{$property} | |
| !== $value |
|
From the customer reporting the issue: https://secure.helpscout.net/conversation/1844626136/896914?folderId=284418
|
|
This is one of the sites having issues on ES: https://originatorconnect.eventsmart.com/wp-admin/admin.php?page=espresso_promotions |
|
fix pushed to MENW && the plz confirm the fix. you will need to create a lot of events (10+) |
|
These are the issues I'm having here: https://garth47.makeeventsnotwar.com/wp-admin/admin.php?page=espresso_promotions&action=create_new
|
|
Still having these issues on the promotions editor as reported above ^. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
better datepickers
better filters
better events list
better pagination