EA-3705 adapt interfaces #47
Conversation
| if (e instanceof ExternalServiceException) { | ||
| // throw gateway timeout (504) for External service call exceptions. | ||
| // This will also include the Resource Exhausted Exception | ||
| throw new LanguageDetectionException(e.getMessage(), HttpStatus.GATEWAY_TIMEOUT.value(), e); |
There was a problem hiding this comment.
actually we should have ExternalServiceException for any 5XX errors. The status code is available in the response, better reuse that value
| if (LOG.isDebugEnabled()) { | ||
| LOG.debug(e.getMessage()); | ||
| } | ||
| throw new LanguageDetectionException(e.getMessage(), HttpStatus.INTERNAL_SERVER_ERROR.value(), e); |
There was a problem hiding this comment.
4XX errors should not be converted to 500, as they need to be fixed/handled by the client
| if (e instanceof ExternalServiceException) { | ||
| // throw gateway timeout (504) for External service call exceptions. | ||
| // This will also include the Resource Exhausted Exception | ||
| throw new TranslationException(e.getMessage(), HttpStatus.GATEWAY_TIMEOUT.value(), e); |
There was a problem hiding this comment.
actually we should have ExternalServiceException for any 5XX errors. The status code is available in the response, better reuse that value
| if (LOG.isDebugEnabled()) { | ||
| LOG.debug(e.getMessage()); | ||
| } | ||
| throw new TranslationException(e.getMessage(), HttpStatus.INTERNAL_SERVER_ERROR.value(), e); |
There was a problem hiding this comment.
4XX errors should not be converted to 500, as they need to be fixed/handled by the client. Better use exception handling by status code than by using the instanceOf
| * @param languageDetectionObjs | ||
| * @return | ||
| */ | ||
| public static LangDetectRequest createLangDetectRequest(List<LanguageDetectionObj> languageDetectionObjs) { |
There was a problem hiding this comment.
this looks more like a factory method which can be implemented directly in the class that fires the request. There is no reason to have this as a static method
| * @return | ||
| */ | ||
| public static TranslationRequest createTranslationRequest(List<TranslationObj> translationStrings) { | ||
| TranslationRequest translationRequest = new TranslationRequest(); |
There was a problem hiding this comment.
this looks more like a factory method which can be implemented directly in the class that fires the request. There is no reason to have this as a static method
…a/translation-api into EA-3705_adaptInterfaces
No description provided.