improved sonar bugs and smells

europeana · Nov 29, 2023 · 8a13b02 · 8a13b02
1 parent 720a6c7
commit 8a13b02
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 5 deletions.
diff --git a/...in/java/eu/europeana/api/translation/definitions/exceptions/InvalidLanguageException.java b/...in/java/eu/europeana/api/translation/definitions/exceptions/InvalidLanguageException.java
@@ -10,4 +10,8 @@ public class InvalidLanguageException extends Exception{
   public InvalidLanguageException(String message) {
     super(message);
   }
+
+  public InvalidLanguageException(String message, Throwable cause) {
+    super(message, cause);
+  }
 }
diff --git a/...definitions/src/main/java/eu/europeana/api/translation/definitions/language/Language.java b/...definitions/src/main/java/eu/europeana/api/translation/definitions/language/Language.java
@@ -45,7 +45,7 @@ public static Language validateSingle(String languageAbbrevation) throws Invalid
         try {
             result = Language.valueOf(languageAbbrevation.trim().toUpperCase(Locale.ROOT));
         } catch (IllegalArgumentException e) {
-            throw new InvalidLanguageException("Language value '" + languageAbbrevation + "' is not valid");
+            throw new InvalidLanguageException("Language value '" + languageAbbrevation + "' is not valid", e);
         }
         return result;
     }
@@ -62,8 +62,8 @@ public static List<Language> validateMultiple(String languageAbbrevations) throw
             throw new InvalidLanguageException("Empty language value");
         }
 
-        List<Language> result = new ArrayList<>();
         String[] languages = languageAbbrevations.split(SEPARATOR);
+        List<Language> result = new ArrayList<>(languages.length);
         for (String language: languages) {
             result.add(validateSingle(language));
         }

diff --git a/...rc/main/java/eu/europeana/translation/service/apachetika/ApacheTikaLangDetectService.java b/...rc/main/java/eu/europeana/translation/service/apachetika/ApacheTikaLangDetectService.java
@@ -40,7 +40,7 @@ public List<String> detectLang(List<String> texts, String langHint) throws Langu
       return Collections.emptyList();
     }
 
-    List<String> detectedLangs = new ArrayList<>();
+    List<String> detectedLangs = new ArrayList<>(texts.size());
     List<LanguageResult> tikaLanguages=null;
     for(String text : texts) {
       //returns all tika languages sorted by score

diff --git a/...slation-web/src/main/java/eu/europeana/api/translation/web/service/RedisCacheService.java b/...slation-web/src/main/java/eu/europeana/api/translation/web/service/RedisCacheService.java
@@ -53,8 +53,9 @@ public void fillWithCachedTranslations(List<TranslationObj> translationObjs) {
     if (redisResponse == null || redisResponse.size() != cacheableTranslations.size()) {
       // ensure that the response size corresponds to request size
       // this should not happen, but better use defensive programming
+      int redisSize=redisResponse==null ? 0 : redisResponse.size();
       logger.warn("Redis response size {} doesn't match the request size{}, for keys: {}",
-          redisResponse.size(), cacheableTranslations.size(), cacheKeys);
+          redisSize, cacheableTranslations.size(), cacheKeys);
       return;
     }
 

diff --git a/...ion-web/src/main/java/eu/europeana/api/translation/web/service/TranslationWebService.java b/...ion-web/src/main/java/eu/europeana/api/translation/web/service/TranslationWebService.java
@@ -125,7 +125,7 @@ CachedTranslationService instantiateCachedTranslationService(boolean useCaching,
 
   private List<TranslationObj> buildTranslationObjectList(TranslationRequest translationRequest) {
     // create a list of objects to be translated
-    List<TranslationObj> translObjs = new ArrayList<TranslationObj>();
+    List<TranslationObj> translObjs = new ArrayList<TranslationObj>(translationRequest.getText().size());
     for (String inputText : translationRequest.getText()) {
       TranslationObj newTranslObj = new TranslationObj();
       newTranslObj.setSourceLang(translationRequest.getSource());