addressing code quality issues EA-3626

europeana · Dec 4, 2023 · 58d21c4 · 58d21c4
1 parent 50ddd75
commit 58d21c4
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 13 deletions.
diff --git a/translation-web/src/main/java/eu/europeana/api/translation/config/TranslationConfig.java b/translation-web/src/main/java/eu/europeana/api/translation/config/TranslationConfig.java
@@ -3,8 +3,6 @@
 import java.util.ArrayList;
 import java.util.List;
 import org.apache.commons.lang3.StringUtils;
-import org.apache.logging.log4j.LogManager;
-import org.apache.logging.log4j.Logger;
 import org.springframework.beans.factory.annotation.Value;
 import org.springframework.context.annotation.Configuration;
 import org.springframework.context.annotation.PropertySource;
@@ -19,12 +17,10 @@
 @PropertySource(value = "translation.user.properties", ignoreResourceNotFound = true)})
 public class TranslationConfig{
 
-  private static final Logger LOG = LogManager.getLogger(TranslationConfig.class);
   /** Matches spring.profiles.active property in test/resource application.properties file */
   public static final String ACTIVE_TEST_PROFILE = "test";
 
   @Value("${europeana.apikey.jwttoken.signaturekey:}")
-//  @Value("${europeana.signaturekey:}")
   private String apiKeyPublicKey;
 
   @Value("${authorization.api.name: translations}")
@@ -36,9 +32,6 @@ public class TranslationConfig{
   @Value("${auth.write.enabled: true}")
   private boolean authWriteEnabled;
 
-  @Value("${spring.profiles.active:}")
-  private String activeProfileString;
-
   @Value("${europeana.apikey.serviceurl:}")
   private String apiKeyUrl;
 
@@ -64,7 +57,7 @@ public class TranslationConfig{
   private String truststorePass;
 
   public TranslationConfig() {
-    LOG.info("Initializing TranslConfigProperties bean.");
+    super();
   }
 
   public String getApiKeyPublicKey() {
@@ -103,10 +96,6 @@ public void setTranslationGoogleProjectId(String googleTranslateProjectId) {
     this.googleTranslateProjectId = googleTranslateProjectId;
   }
 
-//  public static boolean testProfileNotActive(String activeProfileString) {
-//    return Arrays.stream(activeProfileString.split(",")).noneMatch(ACTIVE_TEST_PROFILE::equals);
-//  }
-
   /** verify properties */
   public void verifyRequiredProperties() {
     List<String> missingProps = new ArrayList<>();

diff --git a/...ion-web/src/main/java/eu/europeana/api/translation/serialization/JsonRedisSerializer.java b/...ion-web/src/main/java/eu/europeana/api/translation/serialization/JsonRedisSerializer.java
@@ -32,7 +32,7 @@ public byte[] serialize(Object t) throws SerializationException {
   }
 
   @Override
-  @SuppressWarnings("external_fbcontrib:LEST_LOST_EXCEPTION_STACK_TRACE") // cannot change external interface
+  @SuppressWarnings({"external_fbcontrib:LEST_LOST_EXCEPTION_STACK_TRACE", "external_fbcontrib:EXS_EXCEPTION_SOFTENING_NO_CONSTRAINTS"}) // cannot change external interface
   public CachedTranslation deserialize(byte[] bytes) throws SerializationException {
     if(bytes == null){
       return null;