sonar cloud fixes

europeana · Apr 15, 2024 · 3eee219 · 3eee219
1 parent 8950eed
commit 3eee219
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/...ava/eu/europeana/api/translation/service/etranslation/ETranslationTranslationService.java b/...ava/eu/europeana/api/translation/service/etranslation/ETranslationTranslationService.java
@@ -66,7 +66,7 @@ public ETranslationTranslationService(String baseUrl, String domain, String call
 
   private void validateETranslConfigParams(String baseUrl, String domain, String callbackUrl, 
       int maxWaitMillisec, String username, String password) throws TranslationException {
-    StringBuilder missingParams=new StringBuilder(100);
+    StringBuilder missingParams=new StringBuilder();
     if(StringUtils.isBlank(baseUrl)) {
       missingParams.append("baseUrl");
     }
@@ -186,7 +186,7 @@ private void createRedisMessageListenerAndWaitForResults(List<TranslationObj> tr
    * @throws TranslationException 
    */
   private String generateJointHtmlForTranslation(List<TranslationObj> translationObjs) throws TranslationException {
-    StringBuilder translJointString=new StringBuilder(100);
+    StringBuilder translJointString=new StringBuilder();
     translJointString.append("<!DOCTYPE html>\n<htlm>\n<body>\n");
     for(TranslationObj translObj : translationObjs) {
       translJointString.append("<p>");

diff --git a/...on-web/src/main/java/eu/europeana/api/translation/web/ETranslationCallbackController.java b/...on-web/src/main/java/eu/europeana/api/translation/web/ETranslationCallbackController.java
@@ -32,8 +32,7 @@ public void eTranslationCallback(
       @RequestParam(value = "external-reference", required = true) String externalReference,
       @RequestBody String body) {
     if(LOGGER.isDebugEnabled()) {
-      LOGGER.debug("eTranslation callback on translation api has been received with the request-id: {}, "
-          + "and the external-reference: {}", requestId, externalReference);
+      LOGGER.debug("eTranslation callback on translation api has been received with the external-reference: {}", externalReference);
     }
     if(externalReference!=null && body!=null) {
       redisTemplate.convertAndSend(externalReference, body);