Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: annotation-highlighting on click #2474

Merged
merged 35 commits into from
Nov 22, 2024
Merged

feat: annotation-highlighting on click #2474

merged 35 commits into from
Nov 22, 2024

Conversation

lbiedinger
Copy link
Member

@lbiedinger lbiedinger commented Nov 11, 2024 •
edited
Loading

  • use olMap.on('click') to trigger lookup of annotations at the clicked coordinate
  • extends the EuropeanaMediaAnnotation with the extent parsed from the xywh for each annotation where available
  • Always loads canvas annotations even when on search, to facilitate clicking on the currently loaded image
  • Reset tab (using composable) to annotations when "map" is clicked so that the selected annotation can be higlighted.

@github-actions GitHub Actions
Copy link

JIRA ticket: EC-6946

@github-actions GitHub Actions
Copy link

Preview deployment: https://pr-2474.portal-js.dev.eanadev.org/

lbiedinger and others added 15 commits November 12, 2024 13:48
@lbiedinger
do not .join annotation fetch calls, just construct array with null v…
3b7b581 
…alue
@lbiedinger
highlight annotation on current page, not from list
935a788
@lbiedinger
on page switch fetch new canvas annotations
43e9deb
@lbiedinger
fix annotation detection for multiple list tabs; fix spec for setting…
58be5fc 
… from query;
@lbiedinger
refactor switching to annotations tab
7602848
@lbiedinger
page change clears annotations; set annotation via route on canvas click
6d4acfe
@lbiedinger
merge master resolve conflicts
9ecf8ee
@lbiedinger
unit test
4195f94
@lbiedinger
merge master; resolve conflicts
e784e3f
@lbiedinger
merge master; resolve conflicts
43a185c
@lbiedinger
Merge branch 'master' into feat/EC-6946-annotation-highlighting
16d96be
@lbiedinger
select highlighted annotation on page change
66d1179
@lbiedinger
watch fetchstate for activeAnnotation scroll
9945f6c
@rwd
Merge branch 'master' into feat/EC-6946-annotation-highlighting
4acb5a1
@rwd
refactor: scroll to annotation when set from route query
ea71118
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@LeoniePeters LeoniePeters merged commit 13e8caa into master Nov 22, 2024
17 checks passed
@LeoniePeters LeoniePeters deleted the feat/EC-6946-annotation-highlighting branch November 22, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwd rwd rwd left review comments

@LeoniePeters LeoniePeters LeoniePeters approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lbiedinger @rwd @LeoniePeters