chore: media presentation error handling #2468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rwd
commented
Nov 4, 2024
•
rwd
commented
- add custom error classes and messages to help differentiate the cause of various media presentation errors:
- ItemMediaPresentationError for errors occurring within ItemMediaPresentation component:
- no manifest or web resources to render
- no canvases to render on retrieved manifest
- MediaImageViewerError for errors occurring within MediaImageViewerError component:
- various error, imageloaderror and tileloaderror events from instances of OpenLayers classes
- no image layer to annotate
- IIIFInfoJsonError for failure to retrieve IIIF Image info.json resources
- IIIFManifestError for failure to retrieve IIIF Presentation manifest resources
- ItemMediaPresentationError for errors occurring within ItemMediaPresentation component:
- when such errors are encountered, ItemMediaPresentation component will log them to APM and display the IIIFErrorMessage component in the viewer area
- show the loading spinner in ItemMediaPresentation while waiting for manifest to load
- set a timeout of 10 seconds on media resource (manifest, info.json, annotations, etc) retrieval
|
JIRA ticket: EC-6951 |
|
Preview deployment: https://pr-2468.portal-js.dev.eanadev.org/ |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.