refactor: move CTF assets plugin to utils #2362
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rwd
commented
Jun 12, 2024
•
rwd
commented
- move Contentful assets helper functions from contentful module/plugin to a utils library
- rename exported functions to include "contentful"
- remove contentful store module
- was used to detect and store the client's accepted image formats to only return WebP when they support it, but the browser versions we target all do support WebP, so it's extraneous
- i.e. always return WebP unless format is specified or original is an SVG
|
Preview deployment: https://pr-2362.portal-js.dev.eanadev.org/ |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.