Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add P3 examples #52
Add P3 examples #52
Changes from 24 commits
2f39e0e
2e7e5e3
3dbbe35
503f696
12701c1
dee00e6
acac4cc
fd1a8cc
2b2e333
76a3936
aa5e288
145679d
31aa0e5
e3eb9c5
becf006
4830c7b
eb51a13
1343992
b4df2c1
6bac1bb
9a1f4f7
869045c
9bfaa05
1a6facc
6d1dc76
82c3bee
b58687c
d82bef7
c15adb9
c2d9e62
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably. However I am yet undecided if the
eurec4a
module should grow larger than accessing EUREC4A data and metadata. I think functions like those should either be in a generic campaign data analysis package or we should make chapters of the book importable (#28).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure the best way forward. All the mapping stuff in my contributions comes from Bjorn in any case. It does seem strange to have to repeat code in every document independently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tend to go towards importable book chapters, but I am afraid that I won't be able to do that right now... Thus for now, we probably need to stick a little with repeated code.