-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fetch API types as accepted mock parameters #291
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhaligowski
force-pushed
the
add-fetch-api
branch
from
January 7, 2024 08:10
965c35f
to
87c2aba
Compare
mhaligowski
force-pushed
the
add-fetch-api
branch
from
January 7, 2024 08:23
87c2aba
to
1407b25
Compare
Stale pull request message |
@eugef what's up with this? I guess I need to update the branch, right? |
Hi @mhaligowski If you can run |
Stale pull request message |
Hi @mhaligowski Can you please run |
@eugef sorry, on it! |
@mhaligowski no problem, thanks for updating PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Fetch API's
Request
andResponse
objects to accepted generic types, allowing for using objects that extend this, e.g. NextJS App Router.fixes #233