Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/readme update #108

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Feat/readme update #108

merged 4 commits into from
Feb 6, 2024

Conversation

dzarras
Copy link
Contributor

@dzarras dzarras commented Feb 6, 2024

Closes #102

@babisRoutis, @vafeini Is there anything else that needs to be updated?

@dzarras dzarras added documentation Improvements or additions to documentation feature New feature or request labels Feb 6, 2024
@dzarras dzarras requested a review from babisRoutis February 6, 2024 09:07
@dzarras dzarras requested a review from a team as a code owner February 6, 2024 09:07
babisRoutis
babisRoutis previously approved these changes Feb 6, 2024
@babisRoutis babisRoutis requested a review from vafeini February 6, 2024 11:31
@babisRoutis
Copy link
Contributor

@vafeini Can you please also check this?
From my side seems OK.

@vafeini
Copy link
Contributor

vafeini commented Feb 6, 2024

In the sequence diagrams some of the interactions are numbered with the purpose to give some explanation under the diagram and pointers to the endpoints documented in section Endpoints. This is to give an example of how the api is used in the different presentation flows. So either we add this description or we remove the numbering from the diagram.
Specifically the "Get wallet response" in the case of same device is including an additional query parameter (response_code).

@babisRoutis babisRoutis merged commit e25fa16 into eu-digital-identity-wallet:main Feb 6, 2024
1 check passed
@babisRoutis babisRoutis deleted the feat/readme_update branch February 6, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update example in README
3 participants