Add BNB network support and enhance token handling #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rove zero address handling
…d add native balance loading logic
…nd add support for native tokens in the Dex interface
…d enhance pool creation logic
…SwapRouter tests for native token swaps
…ng and native balance loading
…en transfer handling in Pool contract
…nsaction costs and ensure correct ETH balance after swaps
…for accuracy and improve token swap test in ChainbrarySwapRouter
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -69,6 +69,7 @@ | |||
| ); | |||
| } | |||
|
|
|||
| // TODO: This should include the real amount and be called every time the form gets updated | |||
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce support for the BNB network, improve pool creation logic for native tokens, and enhance token handling and balance loading mechanisms. Refactor tests to ensure accuracy in token swaps and liquidity management.